[D8] Getty images Download

Thank you for applying!

2.0.0 is a wrong name for a branch, while 1.0.x is a correct branch name. The 2.0.0 branch needs to be deleted and the correct branch needs to be created.

As side note, why did you create a new branch, when there is already the 1.0.x branch?

Please check the Git settings and verify that git config --get user.email returns an email that is associated with your Drupal.org account. Your commits aren't associated with your account, which usually happens when Git is using an email Drupal.org doesn't know.

• What follows is a quick review of the project; it doesn't mean to be complete
• For every point, the review doesn't make a complete list of lines that should be fixed, but an example of what is wrong in the code
• A review is about code that doesn't follow the coding standards, contains possible security issue, or doesn't correctly use the Drupal API; if a point isn't about that, it makes it clear

getty_images_download.search_form:
  path: '/admin/gettyimages/search'
  defaults:
    _title: 'Search & Download Getty Images'
    _form: '\Drupal\getty_images_download\Form\GettyImageForm'
  requirements:
    _role: 'authenticated'  

getty_images_download.ajax_search_form:
  path: '/admin/gettyimages/ajax-search'
  defaults:
    _title: 'Search & Download Getty Images'
    _controller: '\Drupal\getty_images_download\Controller\GettyimagesController::openGettyImageSearchForm'
  requirements:
    _role: 'authenticated'

getty_images_download.settings_form:
  path: '/admin/config/system/gettyimageserver'
  defaults:
    _title: 'Getty Images Server API Access Configuration'
    _form: 'Drupal\getty_images_download\Form\SettingsForm'
  requirements:
    _permission: 'administrator'

While it's possible to set the role that is allowed to see a route, it's preferable not to use it and instead set the permission required to access the route. In this way, the route could be made visible to any user the site administrator wants. If the route is associated to the authenticated role, it's not possible to make it visible to anonymous users; if the route is associated to the administrator role, the administrator users cannot access it. (I guess _permission: 'administrator' is supposed to be _role: 'administrator'.)

I still have to review all the code. I am not changing status for that reason.

Thanks for your contribution!

manual review:

1. config schema is missing for your configuration, see https://www.drupal.org/docs/8/api/configuration-api/configuration-schema...
2. GettyImageForm: you catch "Exception" but you need to use "\Exception" for the global name space.
3. GettyImageForm::searchApi(): You are disabling SSL validation with "verify => FALSE". Is this necessary? This is bad since it breaks expectations how HTTPS works and is a minor security issue. It should be removed, I assume the service has a valid SSL certificate.
4. GettyImageForm::searchApi(): I think it is not a good idea to directly dump the downloaded images into the root of the public files folder. Can you use your own folder to separate that better from other files?
5. GettyImageForm::searchApi():: "$fileExist = $this->entityTypeManager->getStorage('file')->loadByProperties(['uri' => $uri]);" this line is used twice without any file being created between, so you will get the same result?
6. SettingsForm::validateForm(): Please set the "#required" property for form input fields that are required, then you don't need to validate that yourself manually.

I'm also removing the review bonus tag, there are no reviews of other modules listed in the issue summary.

Adding security tag for the minor security issue.

I am closing this application since there have been replies in the past 5 months.