Closed (fixed)
Project:
Social PWA
Version:
8.x-1.x-dev
Component:
User interface
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
25 Feb 2021 at 09:05 UTC
Updated:
31 Mar 2021 at 17:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
kingdutchThis seems to have been caused by the change in #3083976: Push notifications provider which changed the creation of the forms. As a result the ID of the toggle element has changed but the
main.jswasn't updated.Comment #3
kingdutchThe attached patch does a bit more than is strictly required. Most importantly it pulls apart the logic for installing the service worker and prompting users to enable push notifications from the logic that handles the form on the settings page. This should improve maintainability.
Most importantly for this issue it fixes the selector of the form.
Comment #5
kingdutchComment #6
kingdutch