Hi, there is spellcheck errors on this module. We need to fix them.
/project/app/modules/custom/entity_share/modules/entity_share_async/src/Plugin/QueueWorker/EntityShareAsyncWorker.php:91:17 - Unknown word (synchronise)
/project/app/modules/custom/entity_share/modules/entity_share_client/src/Plugin/ClientAuthorization/Oauth.php:241:33 - Unknown word (initalize)
/project/app/modules/custom/entity_share/modules/entity_share_client/src/Plugin/ClientAuthorization/Oauth.php:248:33 - Unknown word (initalize)
/project/app/modules/custom/entity_share/modules/entity_share_client/src/Plugin/ClientAuthorization/Oauth.php:319:19 - Unknown word (initalize)
/project/app/modules/custom/entity_share/modules/entity_share_client/src/Plugin/EntityShareClient/Processor/EntityReference.php:161:26 - Unknown word (metadatas)
/project/app/modules/custom/entity_share/modules/entity_share_client/src/Service/RemoteManager.php:175:42 - Unknown word (occured)
/project/app/modules/custom/entity_share/modules/entity_share_client/tests/src/Functional/AuthenticationOAuthTest.php:142:32 - Unknown word (initalize)
/project/app/modules/custom/entity_share/modules/entity_share_client/tests/src/Functional/AuthenticationOAuthTest.php:277:32 - Unknown word (initalize)
/project/app/modules/custom/entity_share/README.txt:246:47 - Unknown word (maintainance)
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3200101-2.patch | 5.61 KB | Pooja Ganjage |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
Pooja Ganjage commentedHi,
Creating a patch for this issue.
Please review the patch.
Thanks.
Comment #3
Pooja Ganjage commentedComment #5
bakopIt should be ok ! Can you review what i did please ?
Thanks.
Comment #6
grimreaper@bastienkopka: as there is a public method that had been changed it should be marked as deprecated. I put a link into the review comment.
@Pooja Ganjage:
- @bastienkopka had this issue already assigned, so no need to provide a patch when someone is already working on an issue.
- Also the changes proposed in your patch are not correct.
- @bastienkopka will complete the MR tomorrow, please do not hijack it like in #3193543: Fix phpcs errors warnings.
Comment #7
bakopComment #8
bakopHi,
The deprecated function was added.
Comment #9
grimreaperComment #11
grimreaper