Closed (fixed)
Project:
Entity Share
Version:
8.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
23 Feb 2021 at 08:59 UTC
Updated:
9 Mar 2021 at 10:54 UTC
Jump to comment: Most recent
FILE: /builds/florenttorregrosa-drupal/docker-drupal-project/app/modules/custom/entity_share/modules/entity_share_client/src/Entity/ImportConfig.php
----------------------------------------------------------------------------------------------------------------------------------------------------
48 | VIOLATION | The property $import_processor_settings is not named in camelCase.
FILE: /builds/florenttorregrosa-drupal/docker-drupal-project/app/modules/custom/entity_share/modules/entity_share_client/src/EntityImportStatusListBuilder.php
--------------------------------------------------------------------------------------------------------------------------------------------------------------
108 | VIOLATION | Avoid using undefined variables such as '$header' which will lead to PHP notices.
109 | VIOLATION | Avoid using undefined variables such as '$header' which will lead to PHP notices.
110 | VIOLATION | Avoid using undefined variables such as '$header' which will lead to PHP notices.
111 | VIOLATION | Avoid using undefined variables such as '$header' which will lead to PHP notices.
112 | VIOLATION | Avoid using undefined variables such as '$header' which will lead to PHP notices.
113 | VIOLATION | Avoid using undefined variables such as '$header' which will lead to PHP notices.
114 | VIOLATION | Avoid using undefined variables such as '$header' which will lead to PHP notices.
115 | VIOLATION | Avoid using undefined variables such as '$header' which will lead to PHP notices.
116 | VIOLATION | Avoid using undefined variables such as '$header' which will lead to PHP notices.
117 | VIOLATION | Avoid using undefined variables such as '$header' which will lead to PHP notices.
118 | VIOLATION | Avoid using undefined variables such as '$header' which will lead to PHP notices.
119 | VIOLATION | Avoid using undefined variables such as '$header' which will lead to PHP notices.
126 | VIOLATION | Avoid using undefined variables such as '$row' which will lead to PHP notices.
132 | VIOLATION | Avoid using undefined variables such as '$row' which will lead to PHP notices.
133 | VIOLATION | Avoid using undefined variables such as '$row' which will lead to PHP notices.
134 | VIOLATION | Avoid using undefined variables such as '$row' which will lead to PHP notices.
139 | VIOLATION | Avoid using undefined variables such as '$row' which will lead to PHP notices.
142 | VIOLATION | Avoid using undefined variables such as '$row' which will lead to PHP notices.
145 | VIOLATION | Avoid using undefined variables such as '$row' which will lead to PHP notices.
148 | VIOLATION | Avoid using undefined variables such as '$row' which will lead to PHP notices.
153 | VIOLATION | Avoid using undefined variables such as '$row' which will lead to PHP notices.
155 | VIOLATION | Avoid using undefined variables such as '$row' which will lead to PHP notices.
157 | VIOLATION | Avoid using undefined variables such as '$row' which will lead to PHP notices.
160 | VIOLATION | Avoid using undefined variables such as '$row' which will lead to PHP notices.
162 | VIOLATION | Avoid using undefined variables such as '$row' which will lead to PHP notices.
FILE: /builds/florenttorregrosa-drupal/docker-drupal-project/app/modules/custom/entity_share/modules/entity_share_client/src/Form/RemoteForm.php
------------------------------------------------------------------------------------------------------------------------------------------------
230 | VIOLATION | The 'getAuthPlugin()' method which returns a boolean should be named 'is...()' or 'has...()'
FILE: /builds/florenttorregrosa-drupal/docker-drupal-project/app/modules/custom/entity_share/modules/entity_share_client/src/Plugin/EntityShareClient/Processor/DefaultDataProcessor.php
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
171 | VIOLATION | Avoid assigning values to variables in if clauses and the like (line '174', column '10').
FILE: /builds/florenttorregrosa-drupal/docker-drupal-project/app/modules/custom/entity_share/modules/entity_share_client/src/Plugin/EntityShareClient/Processor/PhysicalFile.php
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
98 | VIOLATION | Remove error control operator '@' on line 139.
141 | VIOLATION | Missing class import via use statement (line '141', column '23').
FILE: /builds/florenttorregrosa-drupal/docker-drupal-project/app/modules/custom/entity_share/modules/entity_share_client/src/Service/FormHelper.php
---------------------------------------------------------------------------------------------------------------------------------------------------
149 | VIOLATION | Avoid assigning values to variables in if clauses and the like (line '175', column '17').
FILE: /builds/florenttorregrosa-drupal/docker-drupal-project/app/modules/custom/entity_share/modules/entity_share_client/src/Service/ImportConfigManipulator.php
----------------------------------------------------------------------------------------------------------------------------------------------------------------
75 | VIOLATION | Avoid variables with short names like $e. Configured minimum length is 3.
76 | VIOLATION | Missing class import via use statement (line '76', column '19').
109 | VIOLATION | Missing class import via use statement (line '109', column '17').
FILE: /builds/florenttorregrosa-drupal/docker-drupal-project/app/modules/custom/entity_share/modules/entity_share_client/src/Service/ImportService.php
------------------------------------------------------------------------------------------------------------------------------------------------------
122 | VIOLATION | The method importEntities has a boolean flag argument $is_batched, which is a certain sign of a Single Responsibility Principle violation.
FILE: /builds/florenttorregrosa-drupal/docker-drupal-project/app/modules/custom/entity_share/modules/entity_share_client/src/Service/ImportServiceInterface.php
---------------------------------------------------------------------------------------------------------------------------------------------------------------
30 | VIOLATION | The method importEntities has a boolean flag argument $is_batched, which is a certain sign of a Single Responsibility Principle violation.
FILE: /builds/florenttorregrosa-drupal/docker-drupal-project/app/modules/custom/entity_share/modules/entity_share_client/src/Service/StateInformation.php
---------------------------------------------------------------------------------------------------------------------------------------------------------
224 | VIOLATION | Avoid assigning values to variables in if clauses and the like (line '228', column '9').
FILE: /builds/florenttorregrosa-drupal/docker-drupal-project/app/modules/custom/entity_share/modules/entity_share_client/tests/src/Functional/EntityShareClientFunctionalTestBase.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
30 | VIOLATION | The class EntityShareClientFunctionalTestBase has 1003 lines of code. Current threshold is 1000. Avoid really long classes.
30 | VIOLATION | The class EntityShareClientFunctionalTestBase has 20 fields. Consider redesigning EntityShareClientFunctionalTestBase to keep the number of fields under 15.
30 | VIOLATION | The class EntityShareClientFunctionalTestBase has 20 children. Consider to rebalance this class hierarchy to keep number of children under 15.
FILE: /builds/florenttorregrosa-drupal/docker-drupal-project/app/modules/custom/entity_share/modules/entity_share_client/tests/src/Functional/FileTest.php
----------------------------------------------------------------------------------------------------------------------------------------------------------
95 | VIOLATION | Avoid using undefined variables such as '$filesData' which will lead to PHP notices.
98 | VIOLATION | Avoid using undefined variables such as '$filesData' which will lead to PHP notices.
FILE: /builds/florenttorregrosa-drupal/docker-drupal-project/app/modules/custom/entity_share/modules/entity_share_client/tests/src/Functional/MediaEntityReferenceTest.php
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------
82 | VIOLATION | Avoid using undefined variables such as '$filesData' which will lead to PHP notices.
FILE: /builds/florenttorregrosa-drupal/docker-drupal-project/app/modules/custom/entity_share/modules/entity_share_diff/src/Annotation/DiffGenerator.php
-------------------------------------------------------------------------------------------------------------------------------------------------------
17 | VIOLATION | The property $field_types is not named in camelCase.
FILE: /builds/florenttorregrosa-drupal/docker-drupal-project/app/modules/custom/entity_share/modules/entity_share_diff/src/Controller/DiffController.php
--------------------------------------------------------------------------------------------------------------------------------------------------------
131 | VIOLATION | Avoid using undefined variables such as '$header' which will lead to PHP notices.
136 | VIOLATION | Avoid using undefined variables such as '$header' which will lead to PHP notices.
143 | VIOLATION | Avoid using undefined variables such as '$header' which will lead to PHP notices.
148 | VIOLATION | Avoid using undefined variables such as '$header' which will lead to PHP notices.
151 | VIOLATION | Avoid using undefined variables such as '$header' which will lead to PHP notices.
173 | VIOLATION | Avoid using undefined variables such as '$element' which will lead to PHP notices.
174 | VIOLATION | Avoid using undefined variables such as '$element' which will lead to PHP notices.
185 | VIOLATION | Avoid using undefined variables such as '$element' which will lead to PHP notices.
FILE: /builds/florenttorregrosa-drupal/docker-drupal-project/app/modules/custom/entity_share/modules/entity_share_diff/src/Diff/DiffFormatter.php
-------------------------------------------------------------------------------------------------------------------------------------------------
28 | VIOLATION | Avoid assigning values to variables in if clauses and the like (line '31', column '9').
FILE: /builds/florenttorregrosa-drupal/docker-drupal-project/app/modules/custom/entity_share/modules/entity_share_diff/src/DiffGenerator/DiffGeneratorPluginManager.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------
91 | VIOLATION | Avoid unused local variables such as '$weight'.
FILE: /builds/florenttorregrosa-drupal/docker-drupal-project/app/modules/custom/entity_share/modules/entity_share_diff/src/Plugin/DiffGenerator/FileFieldDiffParser.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------
72 | VIOLATION | Avoid unused local variables such as '$remote_item_data'.
FILE: /builds/florenttorregrosa-drupal/docker-drupal-project/app/modules/custom/entity_share/modules/entity_share_diff/src/Service/EntityParser.php
---------------------------------------------------------------------------------------------------------------------------------------------------
290 | VIOLATION | Avoid assigning values to variables in if clauses and the like (line '296', column '11').
FILE: /builds/florenttorregrosa-drupal/docker-drupal-project/app/modules/custom/entity_share/modules/entity_share_server/src/Entity/Channel.php
-----------------------------------------------------------------------------------------------------------------------------------------------
78 | VIOLATION | The property $channel_entity_type is not named in camelCase.
78 | VIOLATION | The property $channel_bundle is not named in camelCase.
78 | VIOLATION | The property $channel_langcode is not named in camelCase.
78 | VIOLATION | The property $channel_filters is not named in camelCase.
78 | VIOLATION | The property $channel_groups is not named in camelCase.
78 | VIOLATION | The property $channel_sorts is not named in camelCase.
78 | VIOLATION | The property $channel_searches is not named in camelCase.
78 | VIOLATION | The property $authorized_users is not named in camelCase.
FILE: /builds/florenttorregrosa-drupal/docker-drupal-project/app/modules/custom/entity_share/src/EntityShareUtility.php
-----------------------------------------------------------------------------------------------------------------------
61 | VIOLATION | Avoid assigning values to variables in if clauses and the like (line '70', column '13').
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
grimreaperComment #5
grimreaper