Problem/Motivation

This issue is to add documentation for the remaining source plugins. It includes all source plugins without documentation that is not covered by child issues of meta task: #3189481: [Meta] Add source plugin documentation to the codebase.

Proposed resolution

Do it.

Remaining tasks

Open a merge request, review, commit.

Issue fork drupal-3199741

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Matroskeen created an issue. See original summary.

Matroskeen opened merge request !336

matroskeen’s picture

matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
commented
Status: Active » Needs review

I must admit, this is pretty straightforward 😅

matroskeen’s picture

matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
commented
Component: documentation » migration system
Issue summary: View changes

changing to migration component

quietone’s picture

quietone commented

This looks fine and can be RTBC. However, I am now thinking that maybe we should expand the scope to include other modules that have source plugins that do not have configuration keys. See my comment in the Meta [#3189481#15]

matroskeen’s picture

matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
commented
Title: Add documentation for aggregator source plugins » Add documentation for remaining source plugins
Status: Needs review » Postponed

Sounds good. We'll get back to this task later :)

matroskeen’s picture

matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
commented
Status: Postponed » Needs review

Added remaining source plugins. Please let me know if the list is too long, I will try to split it up somehow.

matroskeen’s picture

matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
commented
Issue summary: View changes
quietone’s picture

quietone commented
Status: Needs review » Needs work

Nice, good to get this done. I found only two nits.

I made a patch and it is 26K so size of the patch isn't a problem and I don't think the number of files is a problem either. It is the same fix for all of them so let's do it in one go.

matroskeen’s picture

matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
commented
Status: Needs work » Needs review

Easiest fixes ever :) Thanks for the review @quietone!

quietone’s picture

quietone commented
Status: Needs review » Reviewed & tested by the community

@Matroskeen, thanks.

I reviewed the latest changes and they are now consistent with the other source plugins. That was the only item to fix so this is can be RTBC.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Needs work

This needs work to change the @see, https://git.drupalcode.org/project/drupal/-/merge_requests/185#note_25466. Matroskeen and I are working on this.

matroskeen’s picture

matroskeen
Primary language Ukrainian
Location 🇺🇦 Ukraine, Lutsk
commented
Status: Needs work » Needs review

Done 🤓

quietone’s picture

quietone commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

I reviewed that changes in the last commit and they fix the formatting of the sentence before the @see. Since prior to that change this was RTBC I am setting back to RTBC.

Matroskeen closed merge request !336

Matroskeen reopened merge request !336

  • catch committed 1327c4d on 9.3.x 
    Issue #3199741 by Matroskeen, quietone: Add documentation for remaining...
catch’s picture

catch
he/him
Primary language English
commented
Version: 9.3.x-dev » 9.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.3.x and cherry-picked to 9.2.x, thanks!

  • catch committed 0505e48 on 9.2.x 
    Issue #3199741 by Matroskeen, quietone: Add documentation for remaining...

Matroskeen closed merge request !336

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.