Closed (fixed)
Project:
Drupal core
Version:
9.4.x-dev
Component:
jsonapi.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
22 Feb 2021 at 16:28 UTC
Updated:
11 Jan 2022 at 19:39 UTC
Jump to comment: Most recent
Comments
Comment #3
wim leers@bbrala This should be relatively straightforward and would unblock #2794431: [META] Formalize translations support, maybe we can get this going again? :)
Comment #7
bbralaAdding plach for original core. Adding gabesullice for review of code both in #2794431: [META] Formalize translations support
Comment #8
bbralaNot too sure if this is the time to start testing this. Also, not sure we should go about that.
Comment #9
bbralaComment #10
bbralaAppearantly i forgot to change the expected cache tag for the NodeTest. It should now expect the node's language as part of the cache tag :)
Comment #11
wim leersLooking very promising! 👍
Comment #12
bbralaI've addressed all feedback, only one question left regarding the comment/@see target.
Also i've rebased onto 9.3.x, that was a while back.
Comment #13
bbralaCredit @Wim Leers for review.
Comment #14
bbralaComment #15
bbrala(note: if you comment on the issue your avatar will become visible here ;))
Comment #17
bbralaWas that a random rebase? Seems a bit unneeded perhaps? :)
Comment #18
yogeshmpawaryes @bbrala, it was a random rebase.
Comment #19
bradjones1This was split from the parent issue and does not address all issues regarding json:api support for translated content, but it does exactly what the IS says: make the
ResourceObjectvalue object language-aware. The existing test (in the context of a node) does not contain any new test coverage for language handling, merely it is extended to include the language ID in the cache keys.For the narrow purposes for which this ticket is designed, this is RTBC. I only provided reviews on this issue.
Comment #20
bbralaThanks! Adding @bradjones1 to credits :)
Comment #22
bbralaFollowup created #3252424: Follow-up: ResourceObjectNormalizationCacher should get tags from ResourceObject instead of building them
Comment #23
alexpottCommitted and pushed f87303bf2d9 to 10.0.x and 797453145e0 to 9.4.x. Thanks!
This is pretty close to a bug but okay let's put this in as a task and roll on :)
+1 for #3252424: Follow-up: ResourceObjectNormalizationCacher should get tags from ResourceObject instead of building them
Comment #26
bbralaThanks @alexpott! I'll put the follow-up in my backlog ;)
Comment #27
wim leersWOOOT! 🥳
Comment #28
br0kenDoes it need a backport to 9.3.x?