Closed (fixed)
Project:
Paragraphs
Version:
8.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
21 Feb 2021 at 20:05 UTC
Updated:
8 Sep 2022 at 15:14 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #2
nuezComment #3
nuezComment #5
nuezComment #6
nuez1. Added the 'is-active' class to the link instead of the
<li>element- with all corresponding JS changes.2. Wrapped the tabs in a div, so the tabs can be visualised using display:flex (which is what Claro/Gin uses)
3. Put the tabs in a theme function. Although the tabs work with claro now, other teams might want to alter styling even further.
4. Added $.blur() because the tabs were 'hanging in' a ':focus' state causing wrong styling.
This is after the fix:
Comment #7
nuezNot sure if there's a better way, but also uploading the patch to include it in composer.
Comment #8
nuezComment #11
jeroentThe desktop version looks great!
Tests seems to be failing because the tabs are no longer sticky at the top of the page.
Also the tabs are no longer shown on mobile screens:
Comment #12
jeroentI took a bit of a different approach.
I removed the tab classes and created dedicated styling for this element.
The advantage of this approach is that every theme uses these styles as default.
Every theme that wants to improve these element, can override the styles.
Seven:

Gin (or Claro):

Comment #13
jeroentComment #14
jeroentComment #15
romina_ferrario commentedStarted from the beginning and created new patch.



This is how claro looks like with this patch (based on the claro styleguide):
active and not active state:
hover:
focus:
NOTE:
- Seven looks different with this patch but it's not broken.





Seven now:
active and not active state:
hover:
Seven after add the patch:
active and not active state:
hover:
- The mobile view is broken now. I will continue to work on it and fix the mobile view.
Comment #16
romina_ferrario commentedadded a new patch in which desktop and mobile design is fixed
Desktop view:

Mobile view:

Comment #17
jeroentComment #18
romina_ferrario commentedcreated a new patch because I found the classes on claro which includes all styling (for mobile and desktop). Also with this patch seven looks exactly the same as bevor.
Comment #19
berdirwhy is this removed? isn't this for cases when there are no behaviors? make sure it only shows up when you add paragraph types that have behaviors.
Comment #20
romina_ferrario commentedI'm not sure if this is originally written for that, but it's no longer needed. Also not to hide the tabs when there is no Behavior.
Comment #21
mathilde_dumond commentedwith the display: none rule added back-
Comment #22
berdirPatch doesn't apply on 8.x-1.x-dev.
Comment #23
mrinalini9 commentedRerolled patch #21, please review it.
Comment #24
berdirDiscussed, the none css breaks the display: flex through show(). lets change paragraphs-tabs to paragraphs-hide for the none selector and remove/add that class in our JS.
Comment #25
mathilde_dumond commentedComment #26
mathilde_dumond commentednow with the class hide applied from the start
Comment #28
berdirCommitted.