The oEmbed endpoint now returns JSON as the default response instead of XML. Existing code is relying on an XML response so embeds are broken.
View an existing Soundcloudfield embed OR create a new Soundcloudfield and add a URL to a track or set. When the node is viewed, nothing appears. Watchdog will log errors related to SimpleXML not being able to parse.
Change to Json::decode (D8) and drupal_json_decode() (D7) with now default JSON oEmbed response from Soundcloud, replacing simplexml_load_string().
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | 3199360-D7-2.patch | 1.87 KB | vinmassaro |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
vinmassaro commentedComment #3
vinmassaro commentedComment #5
vinmassaro commentedD8 patch file here for testing: https://git.drupalcode.org/project/soundcloudfield/-/merge_requests/1.patch
D7 patch attached.
Comment #6
vinmassaro commentedThese patches require the patches from #3075203: Embed stopped working, update oembed URL to https:// also be applied to totally fix the Soundcloud oEmbed calls.
Comment #7
wlofgren commentedYour patch works great for Drupal 7.
Comment #8
akoepke commentedThanks for this patch! We use this module on D7 and just noticed that all of our embeds were broken.
Frustrating when companies decide to make breaking changes like this.
Comment #9
vinmassaro commentedTo be fair, it looks like this was a really old change: https://developers.soundcloud.com/blog/xml-responses-deprecated
The API request in this module does not specify a format parameter so it seems this has worked for a really long time but should have broken in 2014.
Comment #10
wlofgren commentedI just applied this patch a couple days ago, but now it isn't working. It appears that oEmbed is using xml again because I reverted the patch and the module works again.
Comment #11
vinmassaro commentedWell that's obnoxious. I'm going to update both patches shortly to pass the format parameter since it appears XML is no longer officially supported.
Comment #12
vinmassaro commentedUpdated D7 and D8 patch now enforce
format=jsonin the API request.Comment #13
schillerm commentedHi, I've just tested the latest D7 and D8 patches (on new sites with related patches in #6 installed). Both are working fine.
Comment #16
attila.fekete commentedThank you @vinmassaro and others for pushing this through. Released 8.x-1.0-alpha2 and 7.x-1.5, both include this fix.
Comment #17
vinmassaro commented@attila.fekete Thank you!