Problem/Motivation

While playing around with this handy module i came across, that it lacks some (smaller) changes to work with Drupal 9.

So far i was able to identify the following parts:

  • site_assistant.info.yml needs core_version_requirement block and core dependency to content_translation changes (not sure if the second one is required)
  • drupal_set_message() function calls need to be replaced with Drupal::messenger()->addMessage() in several places
  • AssistantListEntry-Entity lacks some revision metadata keys which leads to an error during module installation

Proposed resolution

Patch follows.

CommentFileSizeAuthor
#5 3198920-5.patch8.01 KBPooja Ganjage
#3 3198920-3-compatibility-with-drupal-9.patch3.23 KBakoe

Comments

akoe created an issue. See original summary.

akoe’s picture

akoe commented
Issue summary: View changes
akoe’s picture

akoe commented
StatusFileSize
new 3198920-3-compatibility-with-drupal-9.patch3.23 KB

A drafted patch, that addresses the three points from #1

lucastockmann’s picture

lucastockmann commented

Hey akoe,

thank you for the patch! I will have time on the weekend to review and test.

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3198920-5.patch8.01 KB

Hi,

Creating a patch for point 2 summary as \Drupal:: calls avoided and instead of that dependency injection is used.

Please review the patch.

Thanks.

Pooja Ganjage’s picture

Pooja Ganjage commented
Status: Active » Needs review
steffenr’s picture

steffenr
Primary language German
Location Bremen
commented
Assigned: Unassigned » steffenr

I'll have a look at the changes. Thx.

steffenr’s picture

steffenr
Primary language German
Location Bremen
commented

@Pooja Ganjage: Thanks for the patch. The changes are available in the latest DEV/ new alpha release of the module.

steffenr’s picture

steffenr
Primary language German
Location Bremen
commented
Assigned: steffenr » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.