Hello,

Using this module can be confusing due to the fact that both link and link_override form elements are shown in all the form types.

In theory, the link element should be used only for the main language and the link_override for the menu link translations.

Here I'm proposing a patch that will hide one or the other based on the from context to make editors life easier.

Thank you!

CommentFileSizeAuthor
#11 3198891-translatable_menu_link_uri-language-based-visibility-11.patch1.4 KBjsobiecki
#3 3198891_3.patch1.34 KBplopesc

Issue fork translatable_menu_link_uri-3198891

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

plopesc created an issue. See original summary.

plopesc opened merge request !1

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
StatusFileSize
new 3198891_3.patch1.34 KB

MR created and patch submitted for reference.

Thank you!

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Active » Needs review

Updating status

akalam’s picture

akalam commented

It works as expected. It display the uri or the link_override field conditionally depending if we are editing or translating a menu_link_content. This is a good UX improvement. Thank you!

liquidcms’s picture

liquidcms commented
Status: Needs review » Reviewed & tested by the community

Seems to work and yes, i suspect only place for this (how did it work before if you had 3 languages?).

Let's get it committed. :)

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Thanks, I agree with the RTBC but it would be great, if you could add a short inline comment above the implementation, what the code does. Perhaps links this issue there. Otherwise that might be hard to get at the first sight.

jsobiecki’s picture

jsobiecki commented

Hello, I'm working on this ticket as part of Drupal Global Contribution Weekend 2023.

I really like this UX improvement. I'll check if it's working OK and add this short code comment (thanks @Anybody) for you.

jsobiecki’s picture

jsobiecki commented
Issue tags: +ContributionWeekend2023
jsobiecki’s picture

jsobiecki commented

I slightly refactored @plopesc patch and added more verbose comment to implementation. I'll commit it to 2.x branch shortly.

Thank you all for contributing!

jsobiecki’s picture

jsobiecki commented
StatusFileSize
new 3198891-translatable_menu_link_uri-language-based-visibility-11.patch1.4 KB

  • jsobiecki committed 49015b56 on 2.x authored by plopesc 
    Issue #3198891 by plopesc, jsobiecki, akalam, liquidcms, Anybody: Show...
jsobiecki’s picture

jsobiecki commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.