Problem/Motivation

When adding a page visibility argument, I get this error.

Steps to reproduce

Add a pingdom rum config, and define a path in 'Add Pingdom RUM monitoring code to specific pages'

Proposed resolution

Looks like a search and replace missed this line and incorrectly changed Unicode::strtolower to Unicode::mb_strtolower

Remaining tasks

Fix bug
Test

CommentFileSizeAuthor
#3 pingdom_rum-strtolower-bug-3197275-3.patch1.17 KBchrisdarke

Issue fork pingdom_rum-3197275

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ChrisDarke created an issue. See original summary.

ChrisDarke opened merge request !1

chrisdarke’s picture

chrisdarke commented
StatusFileSize
new pingdom_rum-strtolower-bug-3197275-3.patch1.17 KB

Including patch file autogenerated from MR:

chrisdarke’s picture

chrisdarke commented
Status: Active » Needs review

  • JamesOakley committed 0baa96f on 2.0.x 
    Issue #3197275 by ChrisDarke: undefined method Unicode::mb_strtolower()
jamesoakley’s picture

jamesoakley
Primary language English
Location North Yorkshire, UK
commented
Status: Needs review » Fixed

Thanks, Chris

I went the other way, and put Unicode::strtolower to the procedural mb_strtolower()

The former was deprecated in Drupal 8.6 and removed in Drupal 9.0.

I also spotted another typo referencing the path alias manager, which I fixed at the same time.

chrisdarke’s picture

chrisdarke commented

Thanks for the quick turnaround!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.