Problem/Motivation

Currently, the tailwindcss.theme file has some code that allows loading the logo from a .png file.
It is generally good practice to use .svg for a logo so the image can scale to any resolution.

Furthermore, this is the default format for a Drupal theme's logo file, which most themes that are based on the toolkit should be using. If a user opts to use a different file format than the default, they ought to bear that responsibility and make the appropriate adjustments as they see fit.

Proposed resolution

Use an svg version of the TailwindCSS logo and remove preprocess code from tailwindcss.theme

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

lhockley created an issue. See original summary.

lhockley’s picture

Status: Active » Needs review
lhockley’s picture

I made a bit of a mess with the commits (I don't do code updates that often on d.o).
But note the merge request is accurately just making edits to 2 files.

opdavies’s picture

Will the logo.svg file be loaded automatically? Or do we need to do anything to use it?

If we're no longer using it, can we remove the logo.png file in this merge request too?

opdavies’s picture

Status: Needs review » Needs work

  • opdavies committed 299f3c7 on 5.x
    Issue #3197081 by lhockley, opdavies: Remove Preprocess Logic; Default...
opdavies’s picture

Status: Needs work » Fixed

This does seem to work as expected using a logo.svg file, so the changes have been committed to the 5.x branch.

Thanks, @lhockley!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.