Adding some ckeditor plugins throws undefined editor.widgets error

Hi there,

We are also having this issue, we have created a new Plugin module for "imagetoolbar", it works initially on page load, but once you open an IEF (Inline Entity Form), it goes blank, we also receive a JS error.

JS ERROR:

Uncaught TypeError: Cannot read property 'on' of undefined
at Object.beforeInit (plugin.js?t=qqqsi5:189)
at Object. (ckeditor.js?v=4.15.1:273)
at n (ckeditor.js?v=4.15.1:253)
at Object.load (ckeditor.js?v=4.15.1:253)
at ckeditor.js?v=4.15.1:273
at window.CKEDITOR.window.CKEDITOR.dom.CKEDITOR.resourceManager. (ckeditor.js?v=4.15.1:260)
at window.CKEDITOR.window.CKEDITOR.dom.CKEDITOR.resourceManager. (ckeditor.js?v=4.15.1:259)
at n (ckeditor.js?v=4.15.1:253)
at Object.load (ckeditor.js?v=4.15.1:253)
at window.CKEDITOR.window.CKEDITOR.dom.CKEDITOR.resourceManager.load (ckeditor.js?v=4.15.1:258)

Line 189: editor.widgets.on('instanceCreated', function (event) {

plugin.js in question is: drupalimage located in core/modules/ckeditor/js/plugins/drupalimage/plugin.js which is triggered

Our Plugin sourcecode:

<?php
namespace Drupal\ckeditor_plugins\Plugin\CKEditorPlugin;

use Drupal\ckeditor\CKEditorPluginInterface;
use Drupal\ckeditor\CKEditorPluginButtonsInterface;
use Drupal\ckeditor\CKEditorPluginContextualInterface;
use Drupal\Component\Plugin\PluginBase;
use Drupal\editor\Entity\Editor;
use Drupal\ckeditor\CKEditorPluginBase;


/**
 * Defines the "imagetoolbar" plugin, with a CKEditor.
 *
 * @CKEditorPlugin(
 *   id = "imagetoolbar",
 *   label = @Translation("Image Toolbar")
 * )
 */
class ImageToolbar extends PluginBase implements CKEditorPluginInterface,CKEditorPluginContextualInterface {

  /**
   * {@inheritdoc}
   */
  public function getDependencies(Editor $editor) {
    return [
    	// 'image2',
      'drupalimage',
    ];
  }
  public function getButtons() {
    return [];
  }
  /**
   * {@inheritdoc}
   */
  public function getLibraries(Editor $editor) {
    return [];
  }

  /**
   * {@inheritdoc}
   */
  public function isInternal() {
    return FALSE;
  }
  /**
   * {@inheritdoc}
   */
  public function isEnabled(Editor $editor){
     return TRUE;
  }

  /**
   * {@inheritdoc}
   */
  public function getFile() {
    // return NULL;
    return drupal_get_path('module', 'ckeditor_plugins') . '/js/plugins/'.$this->getPluginId().'/plugin.js';
  }
  /**
   * {@inheritdoc}
   */
  public function getConfig(Editor $editor) {
    $config = [];
    return $config;
  }

}

Our Drupal environment:

Drupal Core: 9.1.4
PHP: 7.4
CKEditor: 4.15.1
Inline Entity Form Version: 8.x.1.0-rc8

How to produce:

- Install IEF.
- Create a new custom plugin on any CKEditor that uses drupalimage plugin.
- Enable this on the editor settings.
- Create a entity reference within a content type with unlimited cardinality.
- Set Form display to IEF (Complex).

If this is still needed, it will have to be re-rolled against 9.3.x.

It also needs a re-roll to apply after 8.9.19 (which has yet to be merged into 8.9.x).

8.9.19 has now been merged into 8.9.x. This can be put into an issue fork.

The patch needs to update plugin.es6.js from which plugin.js is generated. See "Drupal core now using ES6 for JavaScript development".

Updated patch for CKEditor4 and Drupal 9.5.x

Fixed CCF for #13.

Came up as a daily BSI target

Can anyone confirm this is still an issue in D11?

Going to give 1 more bump before closing.

Since there's been no follow up going to close out. If still valid please re-open.