Problem/Motivation

Add approval systems to process workflow status in K8s launch template (Operation Menus, Buttons)

CommentFileSizeAuthor
#11 3195995-11.diff29.61 KBsekinet
#7 3195995-7.diff24.66 KBsekinet
#6 3195995-6.diff24.68 KBsekinet
#5 3195995-5.diff18.31 KBsekinet
#4 3195995-4.diff19.38 KBsekinet
#3 3195995-3.diff19.3 KBsekinet

Issue fork cloud-3195995

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sekinet created an issue. See original summary.

sekinet opened merge request !132

sekinet’s picture

sekinet commented
StatusFileSize
new 3195995-3.diff19.3 KB
sekinet’s picture

sekinet commented
StatusFileSize
new 3195995-4.diff19.38 KB
sekinet’s picture

sekinet commented
StatusFileSize
new 3195995-5.diff18.31 KB
sekinet’s picture

sekinet commented
StatusFileSize
new 3195995-6.diff24.68 KB
sekinet’s picture

sekinet commented
StatusFileSize
new 3195995-7.diff24.66 KB
sekinet’s picture

sekinet commented

@yas I have created a patch, could you check it?

sekinet’s picture

sekinet commented
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@sekinet

Thank you for adding the feature. Please see my above comments. Thanks

sekinet’s picture

sekinet commented
StatusFileSize
new 3195995-11.diff29.61 KB
sekinet’s picture

sekinet commented
Status: Needs work » Needs review

@yas Thank you for your comments. We have fixed it and created a patch.
Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Add approval systems to process workflow status in K8s launch template (Operation Menus, Buttons) » Add approval systems to process workflow status in K8s launch template (Operation Menus and Buttons)
Status: Needs review » Reviewed & tested by the community

@sekinet

Thank you for the update. I tested the patch with two users (normal and admin user) and it looks working fine. I tested the patch and it looks good to me. I'll merge the patch to 3.x and close this issue as Fixed.

  • yas committed 72a5e30 on 3.x authored by sekinet 
    Issue #3195995 by sekinet, yas: Add approval systems to process workflow...

yas closed merge request !132

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.