Problem/Motivation

We have seen our logging filled up with the following error message.

Notice: Undefined property: stdClass::$elements in template_preprocess_views_view_row_atom() (line 115 of modules/contrib/atom/atom.module).

While investigating the issue I found, that the $item->elements is not defined and therefore empty. Also the array that was supposed to be build here $variables['item_elements'] is not used in the Twig template. This seems to be legacy, which might have been missed out during the Drupal 7 -> Drupal 8 upgrade of the module.

I would vote for just removing those.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork atom-3194242

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

szeidler created an issue. See original summary.

szeidler opened merge request !2

szeidler’s picture

szeidler commented
Status: Active » Needs review

Above you can find a merge request.

  • szeidler committed d4051af on 2.0.x 
    Issue #3194242: $item->elements in preprocess is unused and leads to...
spotzero’s picture

spotzero commented
Status: Needs review » Fixed

Fixed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.