Problem/Motivation

The 'no results' entry of the Sector Events (sector_event) view has obsoleted markup. Additionally, the 'note' library isn't been included and the class on the view has-filters-with-responsive-layout is redundant.

<div class="prose has-margin-top-double">
<div class="note note--primary">
<p class="lead">Sorry. We can't find what you are looking for. You can <a href="/events">reset the filters</a> and try again, or use our <a href="/search">site-wide search</a>.</p>
</div>
</div>

Steps to reproduce

See 'No results behaviour' - /admin/structure/views/view/sector_event/edit/page_1

Proposed resolution

Replace has-margin-top-double with mt-4 and investigate if 'note' is required going forward.

CommentFileSizeAuthor
#3 3193660-3.patch1.78 KBmohit.bansal623

Comments

Chroid created an issue. See original summary.

chroid’s picture

chroid commented
Title: No results has obsoleted markup. » Event view 'No results' has obsoleted markup.
mohit.bansal623’s picture

mohit.bansal623 commented
Status: Active » Needs review
StatusFileSize
new 3193660-3.patch1.78 KB

dieuwe’s picture

dieuwe
Location Auckland, NZ
commented
Status: Needs review » Fixed

I know it's been a long time - but years later and the patch still applies. The 'note' classes are correct and still useful for the Sector theme.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.