Problem/Motivation

The 'site_time_toggle' format setting currently says:

"Site Time" display
Show default site time in parentheses at end of the value if the timezone is overridden. ex. (12:00pm - 1:00pm UTC)

But the code in SmartDateTrait uses $user->getTimeZone() which makes more sense.

Steps to reproduce

Proposed resolution

Change the format setting text to

Append time in user timezone
Show times in the user's timezone, in parentheses at end of the display, if the timezone is overridden. ex. (12:00pm - 1:00pm UTC)

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 3192809-2.patch759 bytesmohit.bansal623

Comments

jonathanshaw created an issue. See original summary.

mohit.bansal623’s picture

mohit.bansal623 commented
Status: Active » Needs review
StatusFileSize
new 3192809-2.patch759 bytes

Changes the text as given. Please review.

jonathanshaw’s picture

jonathanshaw
Primary language English
Location Stroud, UK
commented
Status: Needs review » Reviewed & tested by the community

Nice.

mandclu’s picture

mandclu commented

I'm not sure this new wording is 100% ready. While it's technically accurate in that it reflects what is in the code, for a site that doesn't allow users to override the default time zone (or for users who have not changed their timezone) it will indeed be the site timezone used in the appended time.

mandclu’s picture

mandclu commented
Related issues: +#3188688: 'Site Default' widget timezone setting is misleading
jonathanshaw’s picture

jonathanshaw
Primary language English
Location Stroud, UK
commented

How about
"Show times in the user's preferred timezone (which defaults to the site's configured timezone ..."

mandclu’s picture

mandclu commented

Definitely better. I was actually wondering if the wording should change based on whether or not the site has been configured to allow users to change their timezone, but it's also possible I'm overthinking it...

jonathanshaw’s picture

jonathanshaw
Primary language English
Location Stroud, UK
commented
Status: Reviewed & tested by the community » Needs work

I was actually wondering if the wording should change based on whether or not the site has been configured to allow users to change their timezone, but it's also possible I'm overthinking it..

I suspect so. There's a danger of making the perfect the enemy of the good. Timezones are complex, and trying to magically hide the technical terminology of Drupal's approach is possibly more problematic than exposing it and educating people about it. I tried to find a documentation page we could link to but couldn't.

NW per #6

mandclu’s picture

mandclu commented

Merged in something based on #6, so closing this issue. Feel free to reopen if you think it needs further refinement.

mandclu’s picture

mandclu commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.