Problem/Motivation

The CSV encoder settings can be changed globally with the class the default parameters or by a views plugin but there is no way to override those settings when the serializer/encoder is called manually.

Proposed resolution

The CSV encoder could accept settings as a contextual option.

CommentFileSizeAuthor
#11 csv_serialization-override_encoder_settings_4-3192772-11.patch2.03 KBaerzas
#11 csv_serialization-override_encoder_settings_3-3192772-11.patch2.03 KBaerzas
#5 csv_serialization-override_encoder_settings-3192772-5.patch2.06 KBaerzas
#4 csv_serialization-override_encoder_settings-3192772-4.patch2.03 KBaerzas
#2 csv_serialization-override_encoder_settings-3192772-2.patch1.95 KBaerzas

Issue fork csv_serialization-3192772

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Aerzas created an issue. See original summary.

aerzas’s picture

aerzas commented
StatusFileSize
new csv_serialization-override_encoder_settings-3192772-2.patch1.95 KB
aerzas’s picture

aerzas commented
Status: Active » Needs review
aerzas’s picture

aerzas commented
StatusFileSize
new csv_serialization-override_encoder_settings-3192772-4.patch2.03 KB

Re-rolling against 2.0.

aerzas’s picture

aerzas commented
Issue tags: +Needs review
StatusFileSize
new csv_serialization-override_encoder_settings-3192772-5.patch2.06 KB

Make parameters optional and re-use current value.

acbramley made their first commit to this issue’s fork.

acbramley’s picture

acbramley commented
Issue tags: -Needs review

We have a use case for this as well.

We have a custom batch process seriazling data and writing it to a temp file. We have to manually parse out the header row for anything past the first batch as there's no way currently to disable the header output.

The null coalescing means we can just pass in something like ['output_header' => FALSE] instead of duplicating every setting, nice one :)

Created an MR with #5 rerolled against latest dev.

acbramley opened merge request !24

acbramley’s picture

acbramley commented
Version: 8.x-2.x-dev » 3.x-dev

Ah, didn't realise there was a 3.x branch. I'll reroll against that.

markdorison’s picture

markdorison
he/him
commented
Version: 3.x-dev » 4.x-dev
aerzas’s picture

aerzas commented
StatusFileSize
new csv_serialization-override_encoder_settings_3-3192772-11.patch2.03 KB
new csv_serialization-override_encoder_settings_4-3192772-11.patch2.03 KB

Adding re-rolled patches against the new 3.x and 4.x versions

markdorison’s picture

markdorison
he/him
commented
Status: Needs review » Fixed
markdorison’s picture

markdorison
he/him
commented
//www.flaticon.com/free-icons/thank-you Thank you for your contribution! Your continued support to this project makes other volunteer contributions more sustainable.
There are multiple ways to show appreciation for the work contributed to this project including:
  • Triaging issues and adding more context to existing issues.
  • Writing documentation or patches for this project.
  • Writing blog posts or speaking about it at conferences.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.