Problem/Motivation

Fix a default value of Key Pair in AWS Cloud Launch Template while editing the form

CommentFileSizeAuthor
#6 3192481-6.diff2.16 KBsekinet
#3 3192481-3.diff2.16 KBsekinet

Issue fork cloud-3192481

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sekinet created an issue. See original summary.

sekinet opened merge request !105

sekinet’s picture

sekinet commented
StatusFileSize
new 3192481-3.diff2.16 KB
sekinet’s picture

sekinet commented
Status: Active » Needs review

@yas I created a patch. Could you please check it?
Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@sekinet

Thank you for fixing the issue. Please see my above comment. Basically the code looks good.

sekinet’s picture

sekinet commented
StatusFileSize
new 3192481-6.diff2.16 KB
sekinet’s picture

sekinet commented
Status: Needs work » Needs review

@yas Thank you for your comments. I modified a patch.
Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@sekinet

Thank you for the update. It looks good. I'll merge the patch to 8.x-1.x, 8.x-2.x and 3.x and close this issue as Fixed.

  • yas committed 633996d on 8.x-1.x authored by sekinet 
    Issue #3192481 by sekinet, yas: Fix a default value of Key Pair in AWS...

  • yas committed 53fba1e on 8.x-2.x authored by sekinet 
    Issue #3192481 by sekinet, yas: Fix a default value of Key Pair in AWS...

  • yas committed 2d6e666 on 3.x authored by sekinet 
    Issue #3192481 by sekinet, yas: Fix a default value of Key Pair in AWS...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

yas closed merge request !105

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.