Problem/Motivation

Users with the 'administer workspaces' permission can not create a workspace

Proposed resolution

Allow users with the administer workspaces permission to create workspaces.

Remaining tasks

Review.

User interface changes

Nope.

API changes

Nope.

Data model changes

Nope.

Release notes snippet

Nope.

CommentFileSizeAuthor
#5 interdiff-5.txt863 bytesamateescu
#5 3192292-5.patch2.46 KBamateescu
#2 3192292.patch1.61 KBamateescu
#2 3192292-test-only.patch904 bytesamateescu

Comments

amateescu created an issue. See original summary.

amateescu’s picture

amateescu commented
Status: Active » Needs review
StatusFileSize
new 3192292-test-only.patch904 bytes
new 3192292.patch1.61 KB

This should do it.

The last submitted patch, 2: 3192292-test-only.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 2: 3192292.patch, failed testing. View results

amateescu’s picture

amateescu commented
Status: Needs work » Needs review
StatusFileSize
new 3192292-5.patch2.46 KB
new interdiff-5.txt863 bytes

Fixed those failures. The test-only patch failed as expected.

daffie’s picture

daffie commented
Status: Needs review » Reviewed & tested by the community

The problem from is IS is fixed.
There is testing for the fix.
There is also some extra testing added for the "administer workspaces" permission.
All changes look good to me.
For me it is RTBC.

  • catch committed 7df39b5 on 9.2.x 
    Issue #3192292 by amateescu, daffie: Users with the 'administer...

  • catch committed e0cdb45 on 9.1.x 
    Issue #3192292 by amateescu, daffie: Users with the 'administer...
catch’s picture

catch
he/him
Primary language English
commented
Version: 9.2.x-dev » 9.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 9.2.x and cherry-picked to 9.1.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.