If the theme is installed into themes folder without a subfolder contrib like
/themes/olivero
instead of
/themes/contrib/olivero

the theme logo has a wrong path and is not shown.

How can we repair this?

CommentFileSizeAuthor
#7 site_logo_path_issue-3191808-07.patch646 byteslokeshsahu
#7 after-patch.png80.64 KBlokeshsahu
#7 before-patch.png86.59 KBlokeshsahu

Comments

drupalfan2 created an issue. See original summary.

drupalfan2’s picture

drupalfan2 commented
Title: Theme logo has fix path » Theme logo has fixed path
mohit.bansal623’s picture

mohit.bansal623 commented
Status: Active » Needs review

This is working fine. I am not able to replicate this issue.
Actually this setting "Use the logo supplied by the theme" was not tick in theme settings. I ticked and the logo appears without any issue.

drupalfan2’s picture

drupalfan2 commented

The problem seems to be in debug.js file beginning on line 15:

      if (isChecked) {
        var logoHTML = "\n        <a href=\"/\" rel=\"home\" class=\"site-branding__logo\">\n          <img src=\"/themes/contrib/olivero/logo.svg\" alt=\"Home\">\n        </a>";

        if (currentLogo) {
          headerInner.removeChild(currentLogo);
        }

        headerInner.innerHTML = logoHTML + headerInner.innerHTML;
      } else if (currentLogo) {
        headerInner.removeChild(currentLogo);
      }
    }

In this line:
<img src=\"/themes/contrib/olivero/logo.svg\" alt=\"Home\">\n </a>";
there is a fixed path for the logo.

lokeshsahu’s picture

lokeshsahu commented
Status: Needs review » Active

There is a fixed path for the site logo in debug.js file. That makes the site logo hidden.

lokeshsahu’s picture

lokeshsahu commented
Assigned: Unassigned » lokeshsahu
lokeshsahu’s picture

lokeshsahu commented
StatusFileSize
new before-patch.png86.59 KB
new after-patch.png80.64 KB
new site_logo_path_issue-3191808-07.patch646 bytes

I have created a patch for the above issue and attached a screenshot for reference.
Please review.

lokeshsahu’s picture

lokeshsahu commented
Assigned: lokeshsahu » Unassigned
Status: Active » Needs review

I have created a patch for the above issue and attached a screenshot for reference.
Please review.

drupalfan2’s picture

drupalfan2 commented

Thank you.

But I think we need a different patch. Or even better it would be to change the path problem in dev Version of the Olivero theme.

We need a solution where any path will work, not only a fixed path. Themes can be installed to /themes oder /themes/contrib and any other location like /themes/mycategorie and other variants. Any other path is possible.

drupalfan2’s picture

drupalfan2 commented
Status: Needs review » Needs work
tushar_sachdeva’s picture

tushar_sachdeva commented
Assigned: Unassigned » tushar_sachdeva
tushar_sachdeva’s picture

tushar_sachdeva commented

We can try the path <img src="{{ directory }}/themename/logo.svg" alt="Home\" />,it will solved the path problem in dev Version of the Olivero theme.

tushar_sachdeva’s picture

tushar_sachdeva commented
Assigned: tushar_sachdeva » Unassigned
tushar_sachdeva’s picture

tushar_sachdeva commented
Assigned: Unassigned » tushar_sachdeva
tushar_sachdeva’s picture

tushar_sachdeva commented
Assigned: tushar_sachdeva » Unassigned
seutje’s picture

seutje commented
Status: Needs work » Closed (outdated)

This doesn't really seem relevant anymore since Olivero is in core. Feel free to re-open if I'm mistaken.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.