User deprecated function: Theme functions are deprecated in drupal:8.0.0 and are removed from drupal:10.0.0. Use Twig templates instead of theme_emaillog_admin_settings() [#3190943]

Problem/Motivation

An error displays in the admin UI every time a module is enabled/disabled.
Using Drupal 9.1.0 + Logging and alerts 2.0.x-dev

Steps to reproduce

Navigate to Extend (/admin/modules) and enable a module.
The following error shows up:

 User deprecated function: Theme functions are deprecated in drupal:8.0.0 and are removed from drupal:10.0.0. Use Twig templates instead of theme_emaillog_admin_settings(). See https://www.drupal.org/node/1831138 in Drupal\Core\Theme\Registry->processExtension() (line 498 of core/lib/Drupal/Core/Theme/Registry.php).

Drupal\Core\Theme\Registry->processExtension(Array, 'emaillog', 'module', 'emaillog', 'modules/contrib/logging_alerts/emaillog') (Line: 341)
Drupal\Core\Theme\Registry->build() (Line: 240)
Drupal\Core\Theme\Registry->get() (Line: 88)
Drupal\Core\Utility\ThemeRegistry->initializeRegistry() (Line: 69)
Drupal\Core\Utility\ThemeRegistry->__construct('theme_registry:runtime:claro', Object, Object, Array, 1) (Line: 260)
Drupal\Core\Theme\Registry->getRuntime() (Line: 142)
Drupal\Core\Theme\ThemeManager->render(Array, Array) (Line: 431)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 200)
Drupal\Core\Render\Renderer->render(Array, ) (Line: 241)
Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}() (Line: 573)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 242)
Drupal\Core\Render\MainContent\HtmlRenderer->prepare(Array, Object, Object) (Line: 132)
Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse(Array, Object, Object) (Line: 90)
Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray(Object, 'kernel.view', Object)
call_user_func(Array, Object, 'kernel.view', Object) (Line: 142)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch(Object, 'kernel.view') (Line: 163)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 80)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 706)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Alternatively using drush commands (drush pmu) to uninstall (disable) modules produces the same error to be displayed in the admin UI.

Proposed resolution

Deprecate theme function, as suggested by the error description.

Remaining tasks

User interface changes

API changes

Data model changes

Comment	File	Size	Author
#35	theme_function-3190943-33de7380.patch	5.49 KB	eelkeblok
#10	error_message.png	65.09 KB	larisse

Issue fork logging_alerts-3190943

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

issue/logging_alerts-3190943-render-function changes, plain diff MR !4 / changes, plain diff MR !2 / changes, plain diff MR !3
Check out this branch for the first time

Check out existing branch, if you already have it locally
3190943- compare
Check out this branch for the first time

Check out existing branch, if you already have it locally

2 hidden branches

3190943-user-deprecated-function

changes, plain diff MR !1

Check out this branch for the first time

Check out existing branch, if you already have it locally

3190943-add-d10-compatibility

changes, plain diff MR !5

Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

4 January 2021 at 23:46

jplana created an issue. See original summary.

Comment #2

4 January 2021 at 23:57

joelpittet made their first commit to this issue’s fork.

Comment #3

4 January 2021 at 23:57

joelpittet opened merge request !1

Comment #4

joelpittet

he/him

English

Vancouver

commented 5 January 2021 at 00:18

It will take a bit of wrangling but I'd propose removing the theme_emaillog_admin_settings theme hook all together and building the table and checkboxes in the EmaillogConfigForm::buildForm(),.

Any reason this needs to be themeable? Most anybody doing the same thing would probably do an form alter hook.

Comment #5

khaldoon_masud commented 12 February 2022 at 19:02

Any progress on this?

Comment #6

Tilo Schumann commented 24 February 2022 at 10:46

Comment #7

pedrocorse commented 26 February 2022 at 13:05

Hello,

have you got a solution ?

thanks

Comment #8

paintingguy commented 2 March 2022 at 19:35

same issue, any suggestion on how to resolve this would be grateful. Thank you

Comment #9

abu-zakham commented 2 March 2022 at 19:39

i will look into this asap

Comment #10

larisse commented 7 March 2022 at 17:50

Status	File	Size
new	error_message.png	65.09 KB

I'm facing the same problem in Drupal 9.3.4

Comment #11

leisurman commented 10 March 2022 at 15:19

The error goes away for me when I check 'Use legacy email subject' on the configuration page.
/admin/config/development/emaillog
I was only seeing the error right after logging in, after being logged out.
Using logging_alerts version: '2.0.0'
Drupal version 9.2.13

Comment #12

leisurman commented 3 June 2022 at 14:54

The message is back even after checking 'Use legacy email subject' on the configuration page.
Using logging_alerts version: '2.0.0'
Using Drupal version 9.3.12

Comment #13

_atti_ commented 28 June 2022 at 12:27

Hi! Same issue here with D9.3.15.
The problem is the deprecated render function in emaillog.module / theme_emaillog_admin_settings. It's responsible only for admin view. If you comment this part some info not showing on the admin page, but the function seems work well.

Comment #14

22 July 2022 at 17:15

gruda made their first commit to this issue’s fork.

Comment #15

22 July 2022 at 17:17

gruda opened merge request !2

Comment #16

gruda commented 22 July 2022 at 17:21

This pr will replace the render function as described above.
It will still be necessary to address the theme function issue before Drupal 10.

Comment #17

22 July 2022 at 19:52

abu-zakham closed merge request !2

Comment #18

abu-zakham commented 22 July 2022 at 19:52

Status:

Active

» Fixed

Comment #19

22 July 2022 at 19:57

abu-zakham reopened merge request !2

Comment #20

22 July 2022 at 19:58

abu-zakham committed b40a684 on 2.0.x authored by gruda

Issue #3190943 by joelpittet, gruda, larisse, abu-zakham: User...

Comment #21

abu-zakham commented 22 July 2022 at 20:02

Status:

Fixed

» Closed (fixed)

Comment #22

frosty29 commented 10 August 2022 at 09:31

I don't understand why this is set to closed (fixed). As gurda says #16
"It will still be necessary to address the theme function issue before Drupal 10."
I still get the same warning messages (Drupal 9.4.5, Logging and alerts 2.0.0+1-dev (2022-Jul-22)

Comment #23

abu-zakham commented 11 August 2022 at 07:27

feel free to reopen the issue

Comment #24

abu-zakham commented 11 August 2022 at 07:30

Status:

Closed (fixed)

» Needs work

Comment #25

1 September 2022 at 18:50

sgoodwin made their first commit to this issue’s fork.

Comment #26

1 September 2022 at 19:56

sgoodwin opened merge request !3

Comment #27

1 September 2022 at 20:25

sgoodwin closed merge request !3

Comment #28

1 September 2022 at 20:25

sgoodwin reopened merge request !3

Comment #29

1 September 2022 at 20:27

sgoodwin closed merge request !3

Comment #30

1 September 2022 at 20:29

sgoodwin opened merge request !4

Comment #31

sgoodwin commented 6 September 2022 at 17:37

Status:

Needs work

» Needs review

Changing to needs review. The theme function is removed. Also, the table with checkboxes is moved to the EmaillogConfigForm class.

Comment #32

the_g_bomb commented 8 March 2023 at 17:37

Status:

Needs review

» Reviewed & tested by the community

Patch https://git.drupalcode.org/project/logging_alerts/-/merge_requests/4.diff installs and suppresses the watchdog errors as expected.

Comment #33

6 May 2023 at 00:14

the_g_bomb opened merge request !5

Comment #34

the_g_bomb commented 6 May 2023 at 00:18

Added D10 compatibility
https://git.drupalcode.org/project/logging_alerts/-/merge_requests/5.diff

Try adding the patch with:

composer require mglaman/composer-drupal-lenient
composer config --merge --json extra.drupal-lenient.allowed-list '["drupal/logging_alerts"]'
composer config --json --merge extra.patches.drupal/logging_alerts '{"3190943: User deprecated function": "https://git.drupalcode.org/project/logging_alerts/-/merge_requests/5.diff"}'
composer require --no-update 'drupal/logging_alerts:2.0.x-dev@dev'

composer config repositories.logging_alerts vcs git@git.drupal.org:issue/logging_alerts-3190943.git
composer require --no-update drupal/logging_alerts:dev-3190943-add-d10-compatibility

Comment #35

eelkeblok

he/him

Dutch

Netherlands 🇳🇱

commented 16 May 2023 at 13:38

Status	File	Size
new	theme_function-3190943-33de7380.patch	5.49 KB

Attached is a patch based on MR 4, but against 2.0.0 (the 2.0.x development branch already contains a change for this issue which breaks a patch generated from the pure diff of MR 4).

@the_g_bomb: Is this the only thing standing in the way of D10 compatibility of this module? In that case, I think it might be warranted to add this all in one go. One doubt I have is that the info.yml files claim wider core compatibility (^8...) than the composer.json (^8.8 ...). Maybe (just a suggestion) MR 4 should be merged and the D10-stuff left for a follow-up issue.

Comment #36

27 March 2024 at 23:51

poker10 made their first commit to this issue’s fork.

Comment #37

27 March 2024 at 23:51

poker10 committed 8d35d489 on 2.0.x authored by sgoodwin

Issue #3190943 by joelpittet, gruda, larisse, abu-zakham: User...

Comment #38

poker10 commented 27 March 2024 at 23:54

Status:

Reviewed & tested by the community

» Fixed

I have merged the MR 4 into 2.0.x. Let's continue with all other D10 compatibility issues here: #3390107: Drupal 10 compatibility fixes

Thanks everyone!

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.