Problem/Motivation

The comparison table has "Remove from the list" links built by calling getLink(...)->toString(). This causes the link to be generated and rendered up front. It also makes it hard to alter in hook_entity_comparison_rows_alter. Using toRenderable allows adding classes to the generated link and delays URL generation.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork entity_comparison-3190911

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mglaman created an issue. See original summary.

mglaman opened merge request !1

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Active » Needs review

With this MR proposal, I was able to use the alter and add styling like

$rows[0][$key]['data']['#attributes']['class'][] = 'text-blue-400';
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Reviewed & tested by the community

Seem good enough to me.

  • lobodacyril committed 85d1a1b on 8.x-2.x 
    Issue #3190911 by mglaman: Use toRenderable on the Link object instead...
lobodakyrylo’s picture

lobodakyrylo commented
Status: Reviewed & tested by the community » Fixed
lobodakyrylo’s picture

lobodakyrylo commented
Status: Fixed » Closed (fixed)

mglaman closed merge request !1