Show all selected modules on install confirmation form

Usability review

We discussed this issue at #3191695: Drupal Usability Meeting 2021-01-15. The consensus is that we should have one bullet point (<li> element) for each additional required module. Then list all the selected modules that require it inline. Using the example in the issue summary:

• You must enable the Serialization module to install the following modules: JSON:API, RESTful Web Services.

It will make the list easier to scan for the additional required modules if each one is listed just once. Also, the current solution could be overwhelming if there are a dozen additional modules, each required by 4 or 5 selected modules.

We did not discuss the exact text to use, so feel free to come up with a variant. I used the format above since it avoids worrying about the "and". If there is only one selected module, then use the existing text.

Thanks for the patch, it's been a while so the merge request doesn't apply anymore. we'll need to update the code to 10.1.x

Updated Patch for 10.1.x
Reroll https://git.drupalcode.org/project/drupal/-/merge_requests/201/diffs

1. +++ b/core/modules/system/src/Form/ModulesListConfirmForm.php
   @@ -143,6 +143,23 @@ public function buildForm(array $form, FormStateInterface $form_state) {
   +      // Group up modules only if they have the same dependencies.
   +      $normalized_list = [];
   +      foreach ($this->modules['dependencies'] as $module => $dependencies) {
   +        $module_name = $this->modules['install'][$module];
   +        $hash = hash('sha256', implode(', ', array_keys($dependencies)));
   +        if (!isset($normalized_list[$hash])) {
   +          $normalized_list[$hash] = [
   +            'modules' => [$module_name],
   +            'dependencies' => $dependencies,
   +          ];
   +        }
   +        else {
   +          array_push($normalized_list[$hash]['modules'], $module_name);
   +        }
   +      }
   

   Here $normalized_list is not used anywhere.

   The change to the part of the code below is missing.

2. +++ b/core/modules/system/src/Form/ModulesListForm.php
   @@ -437,14 +437,18 @@ protected function buildModuleList(FormStateInterface $form_state) {
              $dependency_info = $data[$dependency]->info;
   -          $modules['dependencies'][$module][$dependency] = $dependency_info['name'];
   -          $modules['install'][$dependency] = $dependency_info['name'];
   ...
   +            $modules['dependencies'][$module][$dependency] = $data[$dependency]->info['name'];
   +            $modules['install'][$dependency] = $data[$dependency]->info['name'];
   

   would be good to keep the same format as the code it's replacing. There is no reason to change this piece of code, we can add the if around it.

   $dependency_info = $data[$dependency]->info;
   -          $modules['dependencies'][$module][$dependency] = $dependency_info['name'];
   -          $modules['install'][$dependency] = $dependency_info['name'];

I have not seen that issue tag before. It looks as though there are currently 6 issues with the tag, all updated within the last week: https://www.drupal.org/project/issues/search?issue_tags=Needs%20careful%....

We have a MR (Comments 1-9) and a patch (Comment 15). I guess the meaning of the issue tag is to start over from the MR and ignore the patch. I am adding an item to the Remaining tasks in the IS.

yeah added the little text after:

careful reroll
The patch can be tricky to reroll and some code might get lost in the process. When rerolling this issue please make sure all the parts of the patch are kept (new files, new tests, all the changes to the different parts of the file, changes to es6 files ported to .js files, etc.)

I know this needs updated screenshots but the code is available for a review.

What I failed to realize here is that this confirm form was updated after this issue was created and after the Usability review here. It was in #3086941: Improve the required theme/module installation warning which was committed in Aug 2025. That issue correctly includes the all the dependent modules. That makes this issue a duplicate that can be closed.

Any improvements to the confirm form should be done in a new issue.