Drupal 9.1 Deprecated Code Report [#3190816]

drupal-check report results

------ ----------------------------------------------------------------------- 
  Line   src/EventSubscriber/SecKitEventSubscriber.php           
 ------ ----------------------------------------------------------------------- 
  71     Parameter $event of method                                             
         Drupal\seckit\EventSubscriber\SecKitEventSubscriber::onKernelRequest(  
         ) has typehint with deprecated class                                   
         since Symfony 4.3, use RequestEvent instead                            
  86     Parameter $event of method                                             
         Drupal\seckit\EventSubscriber\SecKitEventSubscriber::onKernelResponse  
         () has typehint with deprecated class                                  
         Symfony\Component\HttpKernel\Event\FilterResponseEvent:                
         since Symfony 4.3, use ResponseEvent instead                           
 ------ ----------------------------------------------------------------------- 
 ------ ------------------------------------------------------------ 
  Line   tests/src/Functional/SecKitTestCaseTest.php  
 ------ ------------------------------------------------------------ 
  75     Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  103    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  132    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  161    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  190    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  253    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  268    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  323    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  355    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  364    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  373    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  382    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  391    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  393    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  407    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  409    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  423    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  425    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  434    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  436    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  437    Call to deprecated method assertEqual() of class            
         Drupal\Tests\BrowserTestBase:                               
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use      
  446    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  455    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  464    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  474    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  484    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  512    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  525    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  535    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  547    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  556    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  568    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  577    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  591    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  601    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
  613    Call to deprecated method drupalPostForm() of class         
         Drupal\Tests\BrowserTestBase:                               
         in drupal:9.1.0 and is removed from drupal:10.0.0. Use      
 ------ ------------------------------------------------------------

Comment	File	Size	Author
#16	3190816-16.patch	19.07 KB	sourabhjain
#10	interdiff-3190816-7-9.txt	615 bytes	suzymasri
#10	3190816-9.patch	22.21 KB	suzymasri
#7	3190816-7.patch	22.18 KB	Pooja Ganjage
#6	interdiff-3190816-4-6.txt	709 bytes	suzymasri
#6	3190816-6.patch	19.14 KB	suzymasri
#5	3190816-4.patch	21.13 KB	Pooja Ganjage
#4	interdiff-3190816-2-4.txt	2.39 KB	suzymasri
#4	3190816-4.patch	19.03 KB	suzymasri
#2	3190816-2.patch	17.9 KB	suzymasri

Comments

Comment #1

4 January 2021 at 11:56

suzymasri created an issue. See original summary.

Status	File	Size
new	3190816-2.patch	17.9 KB

Comment #3

4 January 2021 at 12:19

Status:

Needs review

» Needs work

The last submitted patch, 2: 3190816-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #4

suzymasri

Greece

commented 4 January 2021 at 13:42

Status	File	Size
new	3190816-4.patch	19.03 KB
new	interdiff-3190816-2-4.txt	2.39 KB

Updated the patch to cover the below errors:

 ------ ----------------------------------------------------------------------- 
  Line   src/EventSubscriber/SecKitEventSubscriber.php           
 ------ ----------------------------------------------------------------------- 
  71     Parameter $event of method                                             
         Drupal\seckit\EventSubscriber\SecKitEventSubscriber::onKernelRequest(  
         ) has typehint with deprecated class                                   
         since Symfony 4.3, use RequestEvent instead                            
 ------ ----------------------------------------------------------------------- 
 ------ ------------------------------------------------------------ 
  Line   tests/src/Functional/SecKitTestCaseTest.php  
 ------ ------------------------------------------------------------ 
  437    Call to deprecated method assertEqual() of class            
         Drupal\Tests\BrowserTestBase:                               
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use      
 ------ ------------------------------------------------------------

Comment #5

Pooja Ganjage commented 4 January 2021 at 14:04

Status	File	Size
new	3190816-4.patch	21.13 KB

Hi,

Creating a patch for raised issue in #2 comment patch and as well follow to solve deprecated code as per the below link mentioned
https://www.drupal.org/node/3168858

Please review the patch.

Thanks.

Comment #6

suzymasri

Greece

commented 4 January 2021 at 14:38

Status	File	Size
new	3190816-6.patch	19.14 KB
new	interdiff-3190816-4-6.txt	709 bytes

1 file was hidden/shown/deleted

Status	File	Size
hidden	3190816-4.patch	21.13 KB

Thanks @Pooja Ganjage, there aren't any changes between patch #4 and #5, interdiff was empty.

Fixed a missing class issue, patch and interdiff attached.

Comment #7

Pooja Ganjage commented 4 January 2021 at 14:51

Status	File	Size
new	3190816-7.patch	22.18 KB

Comment #8

Pooja Ganjage commented 4 January 2021 at 14:53

Status:

Needs work

» Needs review

Comment #9

4 January 2021 at 14:58

The last submitted patch, 6: 3190816-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #10

suzymasri

Greece

commented 4 January 2021 at 15:17

Status	File	Size
new	3190816-9.patch	22.21 KB
new	interdiff-3190816-7-9.txt	615 bytes

6 files were hidden/shown/deleted

Status	File	Size
hidden	3190816-2.patch	17.9 KB
hidden	3190816-4.patch	19.03 KB
hidden	interdiff-3190816-2-4.txt	2.39 KB
hidden	3190816-6.patch	19.14 KB
hidden	interdiff-3190816-4-6.txt	709 bytes
hidden	3190816-7.patch	22.18 KB

@Pooja Ganjage a minor text change was overridden by your patch #7, it would make it a lot easier for everyone to provide interdiff so the changes are clear, thanks!

Patch updated with text fixes.

Comment #11

timmillwood

English

🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK

commented 5 January 2021 at 08:51

Status:

Needs review

» Reviewed & tested by the community

Looks like the failing test above is on 9.1.0 due to #3186443: PHPUnit 9.5 Call to undefined method ::getAnnotations() which has been committed to 9.1.x and will be released in 9.1.1. The tests are passing fine in 9.1.x and 9.0.10.

Therefore, looks good to me, great to get these deprecations fixed early.

Comment #12

damienmckenna

TN, USA

commented 5 February 2021 at 16:39

Assigned:

suzymasri

» Unassigned

Comment #13

mcdruid commented 28 July 2023 at 14:19

Issue tags:

+Needs reroll

There are a handful of these wide-ranging patches in the queue which all unfortunately require a reroll after some other fixes were committed.

Comment #14

mcdruid commented 31 July 2023 at 12:55

Status:

Reviewed & tested by the community

» Needs work

Comment #15

sourabhjain

English

commented 31 July 2023 at 13:26

Assigned:

Unassigned

» sourabhjain

Comment #16

sourabhjain

English

commented 1 August 2023 at 11:44

Status:

Needs work

» Needs review

Status	File	Size
new	3190816-16.patch	19.07 KB

Created a latest patch. Please review.

Comment #17

silvi.addweb commented 12 June 2024 at 05:35

Status:

Needs review

» Reviewed & tested by the community

I've tested the #16 patch and there are no problems found.

Comment #18

the_g_bomb commented 1 October 2026 at 18:02

Status:	Reviewed & tested by the community	» Closed (outdated)
Issue tags:	-Needs reroll	+Rotterdam2026

I suspect all deprecations listed here were fixed in #3289537: Automated Drupal 10 compatibility fixes. Patch #16 no longer applies. Marking "Closed (outdated)".

Comment #19

1 October 2026 at 18:02

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Drupal 9.1 Deprecated Code Report

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

Comment #16

Comment #17

Comment #18

Comment #19

News items

Our community

Documentation

Drupal code base

Governance of community