CustomElement::setSlotFromNestedElements should never add wrapping elements [#3190611]

Problem/Motivation

Currently CustomElement::setSlotFromNestedElements does not make much sense. It stems from an era where we did not support multiple nested elements for a single slot. However, since that got added CustomElement::setSlotFromNestedElements should do what the name says and not bother about adding wrapping elements.

Issue fork custom_elements-3190611

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3190611-customelementsetslotfromnestedelements-should-never changes, plain diff MR !2
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

1 January 2021 at 21:16

fago created an issue. See original summary.

Comment #2

1 January 2021 at 21:38

fago opened merge request !2

Comment #3

fago

German

Vienna

commented 2 January 2021 at 14:43

Status:

Active

» Needs review

Created a MR for it. This should fix it and the new methods make much more sense. I checked our code at drunomics and it seems this change is not really breaking things, since it does not affect usual usage. Still it *can* break some code and will need a change notice. But since we are only in beta, I think this is fine to do still.