Closed (fixed)
Project:
Drupal core
Version:
9.4.x-dev
Component:
layout_builder.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
31 Dec 2020 at 18:57 UTC
Updated:
16 Jan 2022 at 10:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
tim.plunkettWell spotted. I don't know how we ended up with that code back when we wrote it! Tests sure would have helped.
Comment #3
tim.plunkettOops, blank line.
Comment #5
godotislateNice work! My only nit is that I think the class docblock is not quite accurate about what the cache context is for, or at least, there should be clarification that "layout builder is active" means that the current route entity has overridable layout display.
Comment #7
tim.plunkettAdjusted the docblock, thanks
Comment #8
clayfreemanThis looks great, and is functionally equivalent to what I did separately in #3190542: Layout Builder overrides section storage sets local tasks block cache max-age to 0 on content entity pages without overrides enabled.
Comment #9
godotislate+1 for RTBC
Comment #10
clayfreemanComment #12
clayfreemanTest failure appears to be transient; resetting RTBC.
Comment #14
godotislateBack to RTBC
Comment #17
catchCommitted/pushed to 10.0.x and cherry-picked to 9.4.x, thanks!