t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead

CommentFileSizeAuthor
#2 updated-3190203-2.patch1.71 KBsamvada_jain_m

Issue fork styleguide-3190203

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Samvada_Jain_M created an issue. See original summary.

samvada_jain_m’s picture

samvada_jain_m commented
Assigned: samvada_jain_m » Unassigned
Status: Active » Needs review
StatusFileSize
new updated-3190203-2.patch1.71 KB

Please review.

dcam’s picture

dcam commented
Version: 8.x-1.x-dev » 2.x-dev

dcam opened merge request !27

  • dcam committed 3e0367ed on 2.x 
    Issue #3190203 by dcam, Samvada_Jain_M: Avoid t() calls within class
dcam’s picture

dcam commented
Status: Needs review » Fixed

The same problems existed in the 2.x branch. I didn't find any other instances. Thank you for the patch!

dcam’s picture

dcam commented
Category: Bug report » Task

dcam changed the visibility of the branch 3190203-t-calls-in-class to hidden.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.