Problem/Motivation

  • Implement OpenStackService to use OpenStack native API for Instances Operations
CommentFileSizeAuthor
#13 3189714-13.patch65.59 KBaadil.addweb
#10 3189714-10.patch65.9 KBaadil.addweb
#7 3189714-7.patch64.05 KBaadil.addweb
#3 3189714-2.patch63.61 KBaadil.addweb

Issue fork cloud-3189714

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

binoli.addweb created an issue. See original summary.

binoli.addweb opened merge request !74

aadil.addweb’s picture

aadil.addweb commented
StatusFileSize
new 3189714-2.patch63.61 KB
aadil.addweb’s picture

aadil.addweb commented
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@binoliaddweb

Thank you for the patch. Please see my above comments.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Implement OpenStackService to use OpenStack native API (1.1) (Instances) (Operations) » Implement OpenStackService to use OpenStack native API (Instances) (Operations)
aadil.addweb’s picture

aadil.addweb commented
StatusFileSize
new 3189714-7.patch64.05 KB
aadil.addweb’s picture

aadil.addweb commented
Status: Needs work » Needs review

@yas

Thank you for your review.

I refactored the code as per your comment. Please review the latest patch.

Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@binoliaddweb

Please check my above comment. Temporarily changing the status from Needs review to Needs work.

aadil.addweb’s picture

aadil.addweb commented
StatusFileSize
new 3189714-10.patch65.9 KB
aadil.addweb’s picture

aadil.addweb commented
Status: Needs work » Needs review

@yas

Please review the latest patch.

Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@binoliaddweb

Thank you for the update. Please see my above comments.

Thanks

aadil.addweb’s picture

aadil.addweb commented
StatusFileSize
new 3189714-13.patch65.59 KB
aadil.addweb’s picture

aadil.addweb commented
Status: Needs work » Needs review

@yas

Thank you for your review.

I refactored the code as per your comment. Please review the latest patch.

Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@binoliaddweb

Thank you for the update. I tested the patch and it looks good now. I'll merge the patch to 3.x and close this issue as Fixed.

  • yas committed 3c34fa8 on 3.x authored by binoli.addweb 
    Issue #3189714 by binoli.addweb, yas: Implement OpenStackService to use...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

yas closed merge request !74

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.