The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Problem/Motivation
On patches with changes to nightwatch tests, custom commands don't pass due to the following error:
core/scripts/dev/commit-code-check.sh: line 279: indent: command not found
An example run where this occurs: https://www.drupal.org/pift-ci-job/1924143
Steps to reproduce
Run drupalci tests on a patch that alters a .js file in core/tests/Drupal/Nightwatch
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 3189547-5.patch | 721 bytes | lauriii |
Comments
Comment #2
drummLooks like
indentis a command we can make sure is installed into the test runners, https://www.gnu.org/software/indent/. (Unless this is a npm-provided command, or something other than GNU indent.)Comment #3
drummI think this might be a better project. I think we need to verify which container this command is being run in, and get it added to that container.
Comment #4
bnjmnmBumping this to critical since it blocks any patch with changes in
core/tests/Drupal/Nightwatch/including this critical issue: #3113649: Remove drupal.tabbingmanager's jQueryUI dependencyComment #5
lauriiiWe could probably just remove the indent command because it seems like it was added to improve how the output is formatted. We also have other eslint call used for testing non-Nightwatch files which isn't formatted using indent.
Comment #6
alexpottSo what's really odd is that some DrupalCI environments have indent and some don't. How come. Obviously this is fine to remove. The output is probably not as readable. But it's better than failing.
Comment #7
bnjmnmThe fact that indent isn't being used in other used-more-frequently eslint calls suggests the changes in #5 won't be particularly disruptive or even noticeable. And as #6 stated, it's significantly less disruptive than the fails that are currently happening.
Comment #8
alexpottCommitted and pushed 5fd7a7a165 to 9.2.x and 9145c27667 to 9.1.x and 302effacb2 to 8.9.x. Thanks!