If d7_menu_links depends on d7_menu, then node_translation_menu_links should too

The dependencies will have to go into the optional since node_translation_menu_links.yml is used for D6 and D7

 migration_dependencies:
   optional:
+    - d6_menu
     - d6_menu_links
     - d6_node_translation
+    - d7_menu
     - d7_menu_links
     - d7_node_translation

Updated the patch in #3 as per changes suggested in #5. Thank you!

@ankithashetty, thank for the patch.

Now, with this change why are all tests still passing?

The migration node_translation_menu_links is found in d6/MigrateDrupal6AuditIdsTest.php and d7/MigrateDrupal7AuditIdsTest.php. These tests are checking for ID conflict and are not running the migration so no change is needed in these tests.

It is also found in two migration tests, d6/MigrateMenuLinkTest.php and d7/MigrateMenuLinkTest.php. Both of these run the respective menu migration, indicating that it is needed. Locally, I removed d6_menu and d7_menu and ran the tests. As expected, they failed, thus proving the dependency.

It is probably prudent to make a fail patch to prove this change is correct. So, the next step is to remove d6_menu and d7_menu from the respective migration tests, d6/MigrateMenuLinkTest.php and d7/MigrateMenuLinkTest.php. That will be the fail patch. And the success path is the patch from #6.

Added the Failed patch as suggested in #7. Please review.

@ayushmishra206, thanks for that.

The tests do fail but they don't fail with an expected dependency error, instead it is

1) Drupal\Tests\menu_link_content\Kernel\Migrate\d7\MigrateMenuLinkTest::testMenuLinks
PHPUnit\Framework\Exception: PHP Fatal error:  Uncaught Exception: Serialization of 'Closure' is not allowed in Standard input code:80

and this is due to #3192893: [META] Serialization issues in Migration tests. Applying that patch and running the tests locally result in the expected error

1) Drupal\Tests\menu_link_content\Kernel\Migrate\d6\MigrateMenuLinkTest::testMenuLinks
Migration d6_menu_links did not meet the requirements. Missing migrations d6_menu. requirements: d6_menu.

and

1) Drupal\Tests\menu_link_content\Kernel\Migrate\d7\MigrateMenuLinkTest::testMenuLinks
Migration d7_menu_links did not meet the requirements. Missing migrations d7_menu. requirements: d7_menu.

I hope that is sufficient evidence that the patch here works as expected.

The last thing to do is to upload the success patch so it is the one tested.

Kudos! @quietone

Tests for the latest patch are passing, so this can be RTBC.

Committed and pushed 1d14620445 to 9.2.x and 307f586380 to 9.1.x. Thanks!