In the course of writing up #3188950: Test Coverage: Smart Segment Access Control, I noticed that the schema definition is incomplete for the entities defined by the module. As a result, I had to add protected $strictConfigSchema = FALSE; in order to make the new test pass.
Truth be told, I'm not an expert in this area of Drupal development, so community support would be greatly appreciated!
Remove the strict schema check property and attempt to run the test.
Add the missing schema definitions.
TBD
TBD
TBD
TBD
Passes with #6!
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | smart_content-config_schema-3188961-9.patch | 7.32 KB | gantal |
Comments
Comment #2
michaellander commentedHey @Luke.Leber, thank you for this and your work on the tests. I was just talking with @gantal about this yesterday. Most of it can be copied from 8.x-1.x. I believe he should be getting that setup early next week which should fix any missing schema issues.
Comment #3
luke.leberThanks for the follow-up Michael.
I've sent a couple messages over the #smart_content channel on drupal.slack.com as well if you haven't seen them yet. If you have a few minutes, I'd like to discuss how you would like to work through organizing the testing work. With the new issue forks feature, there's now a number of ways to go about things.
Comment #4
gantal commentedAttaching a patch of my WIP. This corrects decision config schema but the segment set schema still needs updating.
Comment #5
luke.leberComment #6
gantal commentedMore definite config schema in this patch.
Comment #7
luke.leberIt looks like #6 does the trick for getting the test added by https://www.drupal.org/project/smart_content/issues/3188950 to run without
protected $strictConfigSchema = FALSE;.Bravo!
Comment #8
luke.leberComment #9
gantal commentedOne last patch! Left out decision block schema in my last patch; this one includes it. Any residual errors should be gone after #3194816: Group 'op' setting sometimes saved as array and sometimes saved as string is fixed. Thanks for updating the tests and the issue summary, @Luke.Leber!
Comment #11
michaellander commented