Problem/Motivation

The contents of the Entity Reference module have been moved to the base system in #2429191: Deprecate entity_reference.module and move its functionality to core. Then in #3062302: Properly deprecate the entity reference module we discussed the module is already uninstalled on existing sites and we prevent it from being installed in #3111645: Uninstall entity_reference module and prevent it being enabled again, remove deprecated code. This issue is to remove it for good in Drupal 10.

Postponed on the Drupal 10 branch opening.

Proposed resolution

  • rm -rf core/modules/entity_reference
  • (See if any tests fail that test the uninstallability of it for example, remove that too)
  • Git commit

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#13 3188858-13.patch2.92 KBandypost
#13 interdiff.txt860 bytesandypost
#9 3188858-9.patch8.23 KBandypost
#9 interdiff.txt1.02 KBandypost
#6 3188858-6.patch7.2 KBandypost
#5 3188858-5.patch6.61 KBandypost
#5 interdiff.txt6.61 KBandypost
#4 3188858-4.patch605 bytesandypost

Comments

Gábor Hojtsy created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Postponed » Active
andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue tags: +Deprecation Removal
Parent issue: #3062302: Properly deprecate the entity reference module » #3213895: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 10 branch
Related issues: +#3062302: Properly deprecate the entity reference module
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review
StatusFileSize
new 3188858-4.patch605 bytes
andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new interdiff.txt6.61 KB
new 3188858-5.patch6.61 KB

also clean-up composer

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new 3188858-6.patch7.2 KB

full patch

The last submitted patch, 4: 3188858-4.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 6: 3188858-6.patch, failed testing. View results

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1.02 KB
new 3188858-9.patch8.23 KB

Status: Needs review » Needs work

The last submitted patch, 9: 3188858-9.patch, failed testing. View results

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review
Related issues: +#3191559: [random test failure] Random test fail in EntityReferenceWidgetTest

The failure looks random as #3191559: [random test failure] Random test fail in EntityReferenceWidgetTest

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

@andypost do you want to update composer.lock in the same way as the other issue to avoid all those unnecessary changes? Otherwise this looks good to me.

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new interdiff.txt860 bytes
new 3188858-13.patch2.92 KB

Here's it is

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Thanks!

  • catch committed 6c507c3 on 10.0.x 
    Issue #3188858 by andypost, longwave, Gábor Hojtsy: Remove the...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed 6c507c3 and pushed to 10.0.x. Thanks!

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +10.0.0 release notes

Module and theme removals should always be tagged for the release notes. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.