Is it possible to allow us to use different headers instead of just the Authorization? thanks and great module!

CommentFileSizeAuthor
#8 3188409-7-custom-header.patch4.14 KBbryanmanalo
#4 interdiff_2-4.txt1.97 KBreinholdschachner
#4 3188409-2-custom-header-fix.patch3.69 KBreinholdschachner
#2 3188409-1-custom-header.patch2.34 KBmjgruta

Issue fork feeds_http_auth_fetcher-3188409

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mjgruta created an issue. See original summary.

mjgruta’s picture

mjgruta commented
StatusFileSize
new 3188409-1-custom-header.patch2.34 KB

Created a patch that allows you to override the header key.

mjgruta’s picture

mjgruta commented
Status: Active » Needs review
reinholdschachner’s picture

reinholdschachner commented
StatusFileSize
new 3188409-2-custom-header-fix.patch3.69 KB
new interdiff_2-4.txt1.97 KB

Hi!

Thanks for the patch. It didn't work for me though and I made some fixes to it. Now the header key and token should be handled correctly and if the user leaves the key empty, the default Authentication header ist sent.

eidoscom made their first commit to this issue’s fork.

eidoscom opened merge request !7

eidoscom’s picture

eidoscom
Primary language Catalan
commented
Status: Needs review » Reviewed & tested by the community

It is working for me.

bryanmanalo’s picture

bryanmanalo commented
StatusFileSize
new 3188409-7-custom-header.patch4.14 KB

I am having an issue with this if used together with the patch from:
https://git.drupalcode.org/project/feeds_http_auth_fetcher/-/merge_reque...

I had to replace:

$response = $this->get($feed->getSource(), $sink, $cache_key,$feed->getConfigurationFor($this)['token']);

with this

$response = $this->get($feed->getSource(), $sink, $this->getCacheKey($feed), $feed->getConfigurationFor($this)['token']);

Not sure how to update MRs as of this point.

atropoides’s picture

atropoides
He/Him
Location Hamburg
commented

The patch from #8 3188409-7-custom-header.patch worked for me together with the patch from issue #3311889. But I'm not sure how to tackle this, first issue #3311889 has to be merged before we could add these changes to the MR 7.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Assigned: Unassigned » yogeshmpawar

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Assigned: yogeshmpawar » Unassigned
Status: Reviewed & tested by the community » Fixed

Committed & pushed to 2.0.x branch

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.