Needs review
Project:
Flexible Table Of Contents
Version:
2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
13 Dec 2020 at 05:24 UTC
Updated:
26 Mar 2023 at 20:46 UTC
Jump to comment: Most recent
Comments
Comment #2
achandel commentedComment #3
achandel commentedComment #4
e0ipsoPlease, let me know if you find a fix or realize why it was not working.
Comment #5
cfbauer commentedI can confirm it works on 8.9.10 at least, but I noticed it doesn't wok on paragraphs if that's what you're doing.
Comment #6
shriaasSo I just tried to add
labelin the annotation inPlugin\BlockTextLongFieldTocBlockclass, some thing like this:And now I am able to see the block on block administration page XD
The label got overridden
getPreviewFallbackString()but I guess we need to have some default value first to later override it usinggetPreviewFallbackString()Comment #7
e0ipsoGreat finding! Any chance you can submit a merge request or a patch for this?
Comment #9
shriaasDone @e0ipso! Added solution suggested in #6
Comment #10
jjancel commentedwith drupal 9.3.6 the TOC block no longer appears
Solution suggested in #6 does not work
the use is no longer the same as that described
is this project still valid ?
Comment #11
e0ipsoI want to make sure everyone is using
2.xand not8.x-1.xas stated in the issue metadata.Comment #12
e0ipsoCan someone verify if this is an issue in
2.x?Comment #13
vlyalko commentedInstalled 2.x and no configuration option appearing in CT display
Comment #14
Christopher Riley commentedVersion 2.x doesn't show on D9.4 even after downgrading symfony/css-selector to version 4
Comment #15
mlncn commentedComment #16
megakeegman commentedComment #17
megakeegman commentedComment #19
megakeegman commentedI'm not entirely sure what happened here. The MR that was opened #6 does work for 2.x, though the MR was opened to 8.x-1.x. So i opened a new one. I tested and this does fix the issue. Of course, in order to get this far I also needed to create a patch for another issue related to the symfony/css-selector versioning. Though that's a different issue.
Extra note: I pushed this extra branch with
git push table_of_contents-3188114 3188114-2.x-toc-block-doesnt, but for some reason an extra MR seems to have appeared. I'm not sure what happened there, but definitely worth reviewing to make sure nothing fishy made it into this MR. Thanks!Comment #20
megakeegman commentedComment #21
farhanmae commentedIssue still there in v2.0.1 on Drupal 9.5.7