Problem/Motivation
There is currently an inconsistency in the MAINTAINERS.txt file regarding provisional members.
In one section we can see this snippet:
Media Initiative
- Janez Urevc 'slashrsm' https://www.drupal.org/u/slashrsm
PHPUnit Initiative
- Daniel Wehner 'dawehner' https://www.drupal.org/u/dawehner
- (provisional) Michiel Nugter 'michielnugter' https://www.drupal.org/u/michielnugter
- (provisional) Len Swaneveld 'Lendude' https://www.drupal.org/u/lendude
Workflow Initiative
- Dick Olsson 'dixon_' https://www.drupal.org/u/dixon_
Provisional membership: None at this time.
where there is a mismatch between the last sentence and the content above.
(There are indeed provisional memberships)
Steps to reproduce
Review core/MAINTAINERS.txt
Proposed resolution
Discussion with @Gábor Hojtsy and @Rachel Lawson led to the agreement that the line 'Provisional membership: None at this time.' should only be present in a section if there is no provisional members. So in the case where there are provisional members in a section, that line should be removed.
This will be added to documentation in a separate issue.
Remaining tasks
Tidy up MAINTAINERS.txt by removing line 'Provisional membership: None at this time.' where not required.
Issue fork drupal-3187927
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3187927-clean-up-maintainers.txt
changes, plain diff MR !140
Comments
Comment #2
gábor hojtsyRetitled for the specific scope you have here (I think).
Comment #3
chrisdarke commentedThanks! That is a much more clear title!
Comment #4
chrisdarke commentedComment #5
gábor hojtsyI don't think this applies anymore due to #3038234: The PHPUnit Initiative is complete!.
Comment #6
chrisdarke commentedYes but the PHPUnit Initiative was just an example. There are other areas in maintainers where provisional is used. Agree that the maintainers file needs updating in other areas, but the purpose of this was just to bring consistency to the documentation of provisional members across the whole file.
Comment #7
gábor hojtsyPosted this more concrete feedback to make it clear what my point was :)
Comment #8
gábor hojtsyI folded this into #3191699: MAINTAINERS.txt role descriptions outdated, topic maintainer description missing, provisional maintainership incorrect since I was onto fixing various other non-governance formatting issues in the file. Hope to get a review and get it committed soon? :) Credited you there to make sure your finding / credit for your work is not lost.
Comment #9
chrisdarke commentedyeah makes sense to bundle various cleanup bits togther.. cheers!
Comment #10
gábor hojtsyBreaking that up due to disagreements in scoping, however there is also #3195951: Remove "Provisional membership: None at this time" texts from MAINTAINERS.txt now where I credited you. Hopefully it gets resolved somehow soon. Sorry.