Problem/Motivation

Condition if (isset($result['error']) && $result->error) in SettingsForm.php line 73 will never be TRUE, because $result->error can't be called on an array.
Same thing with $result->error_message on line 74, where error_message doesn't exist as getAccountKeys method in case of an error returns array with 'error' and 'content' keys.

Proposed resolution

Correct the code in SettingsForm.php and add tests for this case.

Refers to the Issue 3100567.

Issue fork instapage-3187425

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

timotej-pl created an issue. See original summary.

timotej-pl opened merge request !2

timotej-pl closed merge request !2

timotej-pl opened merge request !5

timotej-pl’s picture

timotej-pl commented
Status: Active » Needs review

bcizej made their first commit to this issue’s fork.

  • bcizej committed 6a392c0 on 8.x-2.x authored by timotej-pl 
    Issue #3187425 by timotej-pl: Unhandled getAccountKeys request in...
bcizej’s picture

bcizej commented
Status: Needs review » Fixed

Thanks, commited.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.