Needs work
Project:
Drupal Commerce Quickbooks Webconnect
Version:
8.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
8 Dec 2020 at 11:25 UTC
Updated:
25 Apr 2022 at 14:00 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #9
shabana.navas commentedComment #10
shabana.navas commentedComment #11
shabana.navas commentedComment #12
shabana.navas commentedComment #16
shabana.navas commentedStill need testing and actual tests.
Comment #20
safallia joseph commentedThe uploaded patch performs the address check and handles the duplicate export and import.
Comment #21
safallia joseph commentedAdded patch in wrong issue. Please ignore #20
Comment #22
benjifisher@shabana.navas, @Safallia Joseph:
Thanks for sharing your work on this issue! I need this feature for my current project, and I am very glad that I do not have to start from scratch.
Can you add some comments to this issue? If you are using this feature on current projects, it would be nice to know that.
It is a little confusing that there are several merge requests (MRs) open for this issue, each with its own branch. I checked out the branch for MR 8, then confirmed that it extends the branches for the other open MRs:
If you need stable patches, so that you can apply them to projects with the
composer-patchesplugin, then you do not need to open separate merge requests.One option is the old-fashioned, approach: attach a patch file to this issue, and then apply that patch. In case you are relying on the current version of MR 8, I am attaching a patch based on that comparing it to the alpha7 release.
I also tagged the current HEAD of the feature branch as
3187201-22and pushed that to the issue fork. Unfortunately, I do not see a way to get a raw diff from GitLab. You can see a comparison as a "friendly" web page: compare 8.x-2.0-alpha7...3187201-22.Comment #23
andrea.cividini commented@benjifisher In the latest patch provided, there's a small configuration error.
On line 1093 the `skip_on_value` configuration is set up wrong:
+ equals: falseThere's no `equals` configuration in that process plugin, only `not_equals` is available.
Comment #24
dchaffin commentedAny idea when these changes will be merged? Thanks!