Groupmedia is a module in Group ecosystem that allows to associate media items to a group. Group module provides plugin manager and interface for associating other entities with group entity. Groupmedia provides the plugin that makes it possible to relate media entity from core with group entity via group content entity.

Project link

https://www.drupal.org/project/groupmedia

Git instructions

git clone --branch 8.x-2.x https://git.drupalcode.org/project/groupmedia.git

PAreview checklist

http://pareview.net/r/23

Comments

a.dmitriiev created an issue. See original summary.

a.dmitriiev’s picture

a.dmitriiev commented
Issue summary: View changes
Status: Active » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
Status: Needs review » Needs work

I added the PAreview checklist link. Reviewers will check the project and post comments to list what should be changed.

If you haven't done it, yet, please check the PAreview report and fix what needs to be fixed. There could be some false positives; verify that what reported is correct, before making any change.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
a.dmitriiev’s picture

a.dmitriiev commented

I fixed all the pareview issues, except for 1, because the annotation uses 'field_types' with underscore, so it should be the same in the class with underscore, as far as I know, or?

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review

Yes, the annotation class properties must match with the properties used in the annotation.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Status: Needs review » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

a.dmitriiev’s picture

a.dmitriiev commented

Thank you @kiamlaluno! Also for the interesting links to read! I will try to check some more pending projects soon.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.