fix deprecated tests for D9x compatibility

Adding a patch.

Trying with the new Gitlab integration in stead :)

Thanks for the new release. I just tried with https://ftp.drupal.org/files/projects/libraries-8.x-3.0-alpha3.tar.gz but got the same error:

Drupal\Core\Extension\InfoParserException: Missing required keys (type) in temporary://update-extraction-67850766/libraries/tests/example/example_info_file.libraries.info.yml in Drupal\Core\Extension\InfoParserDynamic->parse() (line 57 of /app/web/core/lib/Drupal/Core/Extension/InfoParserDynamic.php).

Sorry about the extra releases. I had a look in the code, and there is a reference to an issue, which actually mentions that Libraries API is special, when it comes to testing: #1606606: Drupal.org release packager corrupts info files that are not modules, themes, or install profiles. I am not sure how to proceed ... perhaps @tstoeckler has an opinion on how to get this working?

Files of interest:

src/Tests/LibrariesWebTest.php
tests/example/example_info_file.libraries.info.yml

Should type be unset, like the other fields are here in line 176 of src/Tests/LibrariesWebTest.php?

unset($library['core'], $library['datestamp'], $library['project'], $library['version']);

With what method did you update the module?

Hi @joseph.olstad. The two patches in this issue (local = #3, GitLab = #7) are identical, adding type: module in tests/example/example_info_file.libraries.info.yml, which makes the tests break. So this issue needs more work ...

Great that you got the test thing working @joseph.olstad.

This issue was originally about not being able to download the module from /admin/modules/install or update from /admin/reports/updates/update, and adding type: module. Will the updated test allow this to be added?

I wasn't sure if I needed to create a new branch, but ended up creating another one. I was a little surprised to see the type: module already there ... this new GitLab system takes some getting used to :) And it looks like the test passes.

It's great that the tests are passing, but technically this issue is not fixed, since type: module is still missing from /tests/example/example_info_file.libraries.info.yml . I tried to re-run the test for #3 (adds type: module) which now includes the patch from #24, but it fails ...

Can I ask you to close this no longer relevant Merge Request, @joseph.olstad? https://git.drupalcode.org/project/libraries/-/merge_requests/3
Do you prefer patches uploaded here in the old style, rather than in the new GitLab system?

Updating Issue Summary to use dev-version as example, as well as add update.

Thanks for closing that MR @joseph.olstad. Let's try to deal with this issue with the old patch system here.

I found the CR New 'core_version_requirement' key in info.yml files for modules, themes and profiles allows Composer semantic version constraints including specifying multiple major versions of core, perhaps of use? Based on that I am adding a patch which also includes core_version_requirement: ^8.8 || ^9, let's see what the testbot says.

I had a look at the history of /tests/example/example_info_file.libraries.info.yml and it looks like adding and removing 'type' key has been done before.

• Added in Provide required 'type' key in test library info file. 31. October 2013.
• Removed again in Fix tests a week later, 6. November 2013.

I agree, there is more to be done. My point is, the type was first added and deliberately removed a week later in 2013.

While I think it will be great to get tests working, the issue has now been hijacked, originally about not being able to download and update the module via the GUI.

Wouldn't a better approach be to revert this issue to the original focus (not being able to download the module via GUI) and create a new issue about getting tests working?

Sounds good @joseph.olstad. I'll create a fresh issue for the problem with download/update via GUI. Perhaps you can create one for the test issue?

I have created #3190825: Download or update via the GUI doesn't work. I guess this issue can be kept open, to make the D9 tests work here?