Problem/Motivation

I get several PHP notices while using the module in a PHP 7.4 environment. 

Notice: Trying to access array offset on value of type null in videojs_field_formatter_view() (line 84
Notice: Trying to access array offset on value of type null in videojs_utility::normalizeFieldItems() (line 246
Notice: Undefined index: centeredplaybutton in videojs_field_formatter_view() (line 105 
Notice: Trying to access array offset on value of type null in videojs_field_formatter_view() (line 212

Steps to reproduce

Proposed resolution

Fix PHP notices ;)

Issue fork videojs-3186499

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

SteffenR created an issue. See original summary.

SteffenR opened merge request !1

steffenr’s picture

steffenr
Primary language German
commented
Assigned: steffenr » Unassigned
Status: Active » Needs review
Jorrit’s picture

Jorrit commented

Hi Steffen! Thanks for your contribution. I see changes like:

if (!empty($settings['autoplay']) && $settings['autoplay'] !== NULL) {

But the second part of the if-statement (the old part) is redundant, as !empty($settings['autoplay']) already checks for NULL.

Can you update your MR?

steffenr’s picture

steffenr
Primary language German
commented

@Jorrit: thx for reviewing - you are right - i updated the MR.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Closed (outdated)

Closing this OUTDATED because of Drupal 7 EOL.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.