Problem/Motivation

Minor Typos in below files

asset_injector.module
src/AssetInjectorInterface.php

Steps to reproduce

Refer to the Patch file

Proposed resolution

Need to fix the typo

Remaining tasks

Review

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 interdiff-2-5.txt1.42 KBsivaprasadc
#5 interdiff-2-5.patch1.42 KBsivaprasadc
#5 asset_injector-TypoFix-3186494-5.patch1.82 KBsivaprasadc
#2 asset_injector-TypoFix-3186494-2.patch1.67 KBsivaprasadc

Comments

SivaprasadC created an issue. See original summary.

sivaprasadc’s picture

sivaprasadc commented
Assigned: sivaprasadc » Unassigned
Status: Active » Needs review
StatusFileSize
new asset_injector-TypoFix-3186494-2.patch1.67 KB

Hi,

I have created the patch file. Please refer to the attached.

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Status: Needs review » Needs work 
  1. +++ b/asset_injector.module
@@ -95,8 +95,8 @@ function asset_injector_library_info_build() {
+ * Give the render system the IDs of the currently active assets (that may depend
+ * on the current page and other context - think config overrides). These IDs are
  * mapped to the actual assets in @see asset_injector_library_info_build().

    These lines are not too long. 

  2. +++ b/asset_injector.module
@@ -106,7 +106,7 @@ function asset_injector_library_info_build() {
+ * as the caller already does it. Setting asset entityies' list_cache_tags to

    While we're at it, s/entityies/entities/

sivaprasadc’s picture

sivaprasadc commented
Assigned: Unassigned » sivaprasadc
sivaprasadc’s picture

sivaprasadc commented
Assigned: sivaprasadc » Unassigned
Status: Needs work » Needs review
StatusFileSize
new asset_injector-TypoFix-3186494-5.patch1.82 KB
new interdiff-2-5.patch1.42 KB

Hi @geek-merlin, Thanks for reviewing the patch.

I have recreated the patch with the changes.

sivaprasadc’s picture

sivaprasadc commented
StatusFileSize
new interdiff-2-5.txt1.42 KB

Attached the Interdiff file correctly.

pookmish’s picture

pookmish commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.