Problem/Motivation

Add any / own permissions (17) (Service Accounts)

CommentFileSizeAuthor
#14 3185709-14.patch8.32 KByas
#13 3185709-13.patch8.16 KBsekinet
#11 3185709-11.patch6.51 KByas
#6 3185709-6.patch6.83 KByas

Issue fork cloud-3185709

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sekinet created an issue. See original summary.

sekinet opened merge request !31

sekinet’s picture

sekinet commented
Issue summary: View changes
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@sekinet

I posted my comments. Please fix those.

Thanks

sekinet’s picture

sekinet commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3185709-6.patch6.83 KB

Status: Needs review » Needs work

The last submitted patch, 6: 3185709-6.patch, failed testing. View results

sekinet’s picture

sekinet commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 6: 3185709-6.patch, failed testing. View results

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@sekinet

Can you add the modifications in https://git.drupalcode.org/project/cloud/-/merge_requests/29/diffs like:

  • modules/cloud_service_providers/k8s/tests/src/Functional/K8sPersistentVolumeClaimTest.php
  • modules/cloud_service_providers/k8s/tests/src/Traits/K8sTestFormDataTrait.php
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
StatusFileSize
new 3185709-11.patch6.51 KB

Status: Needs review » Needs work

The last submitted patch, 11: 3185709-11.patch, failed testing. View results

sekinet’s picture

sekinet commented
StatusFileSize
new 3185709-13.patch8.16 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new 3185709-14.patch8.32 KB

@sekinet

Thank you for the update. It looks good to me. I'll merge the patch to 8.x-2.x and 3.x and close this issue as Fixed.

  • yas committed 14861ed on 8.x-2.x authored by sekinet 
    Issue #3185709 by sekinet, yas: Add any / own permissions to Service...

  • yas committed 23e07ce on 3.x authored by sekinet 
    Issue #3185709 by sekinet, yas: Add any / own permissions to Service...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

yas closed merge request !31

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.