Need to revert our testing trait back into a base class and re-run coder.

CommentFileSizeAuthor
#6 3185277-mr9-6.patch12.57 KBmrweiner
#4 3185277-mr9-4.patch10.83 KBmrweiner

Issue fork cache_register-3185277

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mrweiner created an issue. See original summary.

mrweiner opened merge request !9

mrweiner’s picture

mrweiner commented
Status: Active » Needs review
mrweiner’s picture

mrweiner commented
StatusFileSize
new 3185277-mr9-4.patch10.83 KB

Status: Needs review » Needs work

The last submitted patch, 4: 3185277-mr9-4.patch, failed testing. View results

mrweiner’s picture

mrweiner commented
Status: Needs work » Needs review
StatusFileSize
new 3185277-mr9-6.patch12.57 KB

Try with cache::permanent instead of timestamps.

Status: Needs review » Needs work

The last submitted patch, 6: 3185277-mr9-6.patch, failed testing. View results

mrweiner’s picture

mrweiner commented
Status: Needs work » Needs review

Ah, okay WIP merge requests do not fire off tests.

mrweiner opened merge request !10

mrweiner’s picture

mrweiner commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.