Closed (fixed)
Project:
Require on Publish
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
23 Nov 2020 at 18:54 UTC
Updated:
24 Mar 2021 at 04:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
zarpele commentedComment #3
zarpele commentedHey Guys, I spent some time implementing the Remaining tasks, this last patch implements a new "Warning on Empty" checkbox so we can configure these kinds of messages as you want.
Comment #4
zarpele commentedComment #5
graber commentedHi, checked the code and tested this and all looks good :)
Comment #6
mpriscella commentedI like the idea! While thinking about the problem though, it seemed to me that there would probably be very few scenarios where a site administrator would want to hide warnings for one field on an edit form versus another field. The more likely scenario is that a site administrator would want to either hide or show all warnings across the board. I created this patch based off your work that creates a global configuration form for the form where one can toggle the display status of the warning message. Let me know what you think and whether my logic here is flawed.
Comment #7
demonde commented$message = $label . ' can not be empty on publication.';Looks to me as if the message is not translatable by the UI translation interface yet.
Comment #8
zarpele commented> demonde
Yes, i only sent the improvements on the configuration and behavior. The message line was there before my code. Could you create a new issue to face it there?
Comment #9
graber commentedJust to be clear on this, I gave an RTBC to the patch from #3.
I don't think limiting its possibilities as in #6 is a good idea as we can run to other edge cases where site admins will need some messages to display but not all. Better to give full power IMO.
Comment #10
mpriscella commentedFair enough, I'll move the code in #6 to a new issue to compliment (not replace) the functionality in #3.
Comment #12
mpriscella commented