Problem/Motivation

Recently I had to patch MenuLinkManager in order to make a patch related to a pathauto issue to word (see https://www.drupal.org/project/pathauto/issues/3016532#comment-13894750). I came up to ask myself what worked wrong in this really specific case : pathauto ore the MenuLinkManager::updateDefinition ? This issue explores on the second option.

See related issues to reproduce the problem

CommentFileSizeAuthor
#2 3181070-possible-need-to-change-the-way-menulinkmanager-updates-menu-item-and-menu-tree.patch1.16 KBsylvain lavielle

Comments

sylvain lavielle created an issue. See original summary.

sylvain lavielle’s picture

sylvain lavielle commented
StatusFileSize
new 3181070-possible-need-to-change-the-way-menulinkmanager-updates-menu-item-and-menu-tree.patch1.16 KB

Here's a patch.

Disclaimer : This is a quick fix approach, I'm really aware that the proper solution would be more tricky. But this worked for me in conjunction with https://www.drupal.org/project/pathauto/issues/3016532#comment-13885277. It can be a valid workaround for people the time pathauto and possibly drupal core reach a perfect solution about this issue

simon georges’s picture

simon georges commented
Status: Active » Needs review

Changing status to "Needs review", as there is a patch.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

mr.york’s picture

mr.york commented
Status: Needs review » Reviewed & tested by the community

Thank you! Good patch.

catch’s picture

catch
he/him
Primary language English
commented
Category: Feature request » Task
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests, +Needs issue summary update

As explained by the patch author in #2 this isn't a committable patch - it might point to something going wrong, or there might be an alternative fix for pathauto.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.