Closed (fixed)
Project:
Drupal core
Version:
9.1.x-dev
Component:
Olivero theme
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
4 Nov 2020 at 23:04 UTC
Updated:
14 Dec 2020 at 14:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
mherchelThis does the job. Here is a Tugboat URL that shows that the problem is fixed.
https://3180756-audio-lmlsyegmnmgunwmbig49h48ohxd5djm4.tugboat.qa/node/59
Comment #3
ranjith_kumar_k_u commentedThe patch working fine

Before patch
After Patch

RTBC
Comment #4
ranjith_kumar_k_u commentedComment #5
lauriiiIt would be good if we could get some more screenshots on other supported browsers https://www.drupal.org/docs/system-requirements/browser-requirements
Comment #6
anmolgoyal74 commentedThe issue exists on the chrome browser, fixed after the patch.
I have checked it on safari, working fine before and after the patch.
Comment #7
mherchelThanks @anmolgoyal74
Comment #8
lauriiiI'm mostly concerned about removing the display: block declaration because the default value for the property for this element would be inline (at least based on https://developer.mozilla.org/en-US/docs/Web/HTML/Element/audio#Styling_...). I'm also curious if the removal of the max-width declaration has impact on the designs. Wouldn't the correct fix here to remove the height: 0 from audio, but keep the display and max-width intact?
Comment #9
mherchelUpdated patch attached
Comment #10
proeungThe audio is now displayed fine with the patch submitted in #9. Marking this issue as RTBC.
Comment #11
lauriiiimg and video should also get display: block and max-width: 100%.
Comment #12
mherchelGood catch. Updating patch.
Comment #13
proeung@lauriii Great catch!
@mherchel The latest patch looks good!
Comment #16
lauriiiWe should open follow-up to improve the audio styles. For example, I placed audio in the beginning of an article and there was no margin between the image and the audio controls.
Committed f8ad4f8 and pushed to 9.2.x. Also cherry-picked to 9.1.x. Thanks!