The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.- Fix a status message of VPC Peering Connection creation form that shows a successful message while failed
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 3177875-3.patch | 1.63 KB | sekinet |
Comments
Comment #2
sekinet commented@yas
Please review the patch file. Thanks.
Comment #3
yas@sekinet
Thank you for the patch. We need to change the status from Active to Needs review to run the DrupalCI automated testing although it has been broken recently.
Comment #5
sekinet commented@yas
Fixed a change from judging by the presence of an error message to judging by the status of the entity.
Please review the patch file.
Thanks.
Comment #6
yas@sekinet Please change the status from Needs work to Needs review to trigger to start DrupalCI.
Comment #7
yas@sekinet
Thank you for the update. I tested the patch and it looks good; however let me suggest:
With showing the error message, can you show the listing page instead of showing the form with a warning message
During this state, it cannot be accepted, rejected, or deleted. The failed VPC peering connection remains visible to the requester for 2 hours._besides_ the error message as you implementation:The VPC Peering Connection〜 could not be created.(We can remain the message, too.)Comment #8
yas@sekinet
FYI: https://docs.aws.amazon.com/vpc/latest/peering/vpc-peering-basics.html
Comment #9
sekinet commented@yas
Thank you for your advice.
Fixed to redirect to listing page, added error message.
Please review the patch file.
Thanks.
Comment #13
yas@sekinet
Thank you for the update. I tested the patch and it looks good to me. I'll merge the patch to
8.x-1.x,8.x-2.xand3.xand close this issue asFixed.FYI, the patch # should be equal to the comment #.
Comment #14
yas