Problem/Motivation

GroupKernelTestBase.php provides methods to create a new group type and group entity, which is cool, but there is no good way to reuse these methods in other contrib modules that rely on Group module and would like to add some test coverage.

Proposed resolution

Introduce GroupTestTrait.php (similar to TaxonomyTestTrait.php), which will contain helper methods and will be easier to re-use in other modules or test types inside the Group module.

Remaining tasks

Review the patch.

CommentFileSizeAuthor
#2 3177542-2.patch3.26 KBmatroskeen

Issue fork group-3177542

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Matroskeen created an issue. See original summary.

matroskeen’s picture

Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new3.26 KB

Here is a patch,
Thanks!

ekes’s picture

Version: 8.x-1.x-dev » 3.0.x-dev
Component: Group (group) » Code

I've stumbled over this a few times now when updating modules to 3.x (and their tests). I'll push an updated suggestion into a branch.

kristiaanvandeneynde’s picture

Issue tags: +Group 3.3.0

This makes a lot of sense, tagging for 3.3, so that I can add more smaller features into one release.

kristiaanvandeneynde’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.