Comments

andrewmacpherson created an issue. See original summary.

andrewmacpherson’s picture

Adding this placeholder issue (so it has an issue number...).

Discussed with @mherchel, @katannshaw, and the accessibility topic maintainers during the accessibility office hourse meeting (15th Oct 2020).

I'll flesh this out with child issues. I have detailed notes already.

mherchel’s picture

Project: Olivero » Drupal core
Version: 8.x-1.x-dev » 9.1.x-dev
Component: User interface » Olivero theme
Issue tags: +stable blocker
mherchel’s picture

bnjmnm’s picture

Issue summary: View changes
bnjmnm’s picture

Issue summary: View changes
andrewmacpherson’s picture

Issue summary: View changes

Removing a child issue - #3190113: Hover style on level-2 nav not applied to full width of <a> doesn't have much bearing on accessibility.

andrewmacpherson’s picture

andrewmacpherson’s picture

Issue summary: View changes

Note that we (loosely) decided to follow the Link + Disclosure Widget Navigation pattern during the summer last year.

The way this emerged is that we were reviewing the behaviour of the menu at a time when it didn't have the buttons yet. IIRC it was the first time the Olivero team showed the work to the accessibility maintainers, and @mherchel and I continued discussing it on Slack afterwards while he implemented it. After we aligned on the use of a button for each submenu, I noted that it was now becoming VERY similar to the Link + Disclosure Widget Navigation, and proposed that we follow that pattern closely. Meanwhile, @mherchel wrote an article along similar lines; Accessible Navigation with Drupal Core’s Menu System

I don't know if we ever explicitly stated that in the issue queue though. The menu still follows that pattern very closely, so I'm adding it to the issue summary here now. At this stage, I don't think we should depart from that pattern.

andrewmacpherson’s picture

Issue summary: View changes

First cut at must/should/could triage.

mherchel’s picture

mherchel’s picture

Status: Active » Closed (outdated)

Closing this as outdated. All of these issues are being moved into #3177296: [META] Make Olivero stable