This issue is about 2 features in the Olivero header region.
- The feature which shows/hides the entire header content. This is unique to Olivero.
- A menu block placed inside the header. This follows the pattern described at Link + Disclosure Widget Navigation
Bugs
Major Bugs (must-have, stable blockers)
- #3186349: Major accessibility problems with Olivero header show/hide feature
- #3191077: Olivero narrow/mobile menu constrains tabbing in one direction only.
- #3190120: Olivero: Focused level-2 nav items should always be in viewport during keyboard navigation.
- #3192903: Mouseout event should not close navigation sub-menu if focus is inside the sub-menu
Normal bugs (should-have)
- #3180086: It should not be possible to have two dropdown menus appear at the same time within Olivero
- #3190140: Collapsible nav button text should be more descriptive
- #3190137: Refactor aria implementation of collapsible nav
- #3190210: Add arrow key support to navigating level-2 menus
- #3191806: Only close Olivero sub-menus when resize results in a different menu format
Comments
Comment #2
andrewmacpherson commentedAdding this placeholder issue (so it has an issue number...).
Discussed with @mherchel, @katannshaw, and the accessibility topic maintainers during the accessibility office hourse meeting (15th Oct 2020).
I'll flesh this out with child issues. I have detailed notes already.
Comment #3
mherchelComment #4
mherchelAdding #3180086: It should not be possible to have two dropdown menus appear at the same time within Olivero
Comment #5
bnjmnmComment #6
bnjmnmComment #7
andrewmacpherson commentedRemoving a child issue - #3190113: Hover style on level-2 nav not applied to full width of <a> doesn't have much bearing on accessibility.
Comment #8
andrewmacpherson commentedAdded #3191077: Olivero narrow/mobile menu constrains tabbing in one direction only..
Note that this is much more urgent than #3190242: Nav should use core/drupal.tabbingmanager instead of custom focus manager (which is a task, not a bug).
Comment #9
andrewmacpherson commentedNote that we (loosely) decided to follow the Link + Disclosure Widget Navigation pattern during the summer last year.
The way this emerged is that we were reviewing the behaviour of the menu at a time when it didn't have the buttons yet. IIRC it was the first time the Olivero team showed the work to the accessibility maintainers, and @mherchel and I continued discussing it on Slack afterwards while he implemented it. After we aligned on the use of a button for each submenu, I noted that it was now becoming VERY similar to the Link + Disclosure Widget Navigation, and proposed that we follow that pattern closely. Meanwhile, @mherchel wrote an article along similar lines; Accessible Navigation with Drupal Core’s Menu System
I don't know if we ever explicitly stated that in the issue queue though. The menu still follows that pattern very closely, so I'm adding it to the issue summary here now. At this stage, I don't think we should depart from that pattern.
Comment #10
andrewmacpherson commentedFirst cut at must/should/could triage.
Comment #11
andrewmacpherson commentedAdded #3191806: Only close Olivero sub-menus when resize results in a different menu format
Comment #12
andrewmacpherson commentedAdded #3192903: Mouseout event should not close navigation sub-menu if focus is inside the sub-menu
Comment #13
mherchelComment #14
mherchelClosing this as outdated. All of these issues are being moved into #3177296: [META] Make Olivero stable